Skip to content

chore: Update docling-serve container image version to v1.29.0 - #615

Merged
edeandrea merged 3 commits into
mainfrom
docling-serve-1.29.0
Aug 5, 2026
Merged

chore: Update docling-serve container image version to v1.29.0#615
edeandrea merged 3 commits into
mainfrom
docling-serve-1.29.0

Conversation

@edeandrea

Copy link
Copy Markdown
Contributor

Update docling-serve container image version to v1.29.0

Copilot AI lite review requested due to automatic review settings August 5, 2026 13:19
@edeandrea edeandrea changed the title Update docling-serve container image version to v1.29.0 chore: Update docling-serve container image version to v1.29.0 Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default Docling Serve Testcontainers image tag used by docling-testcontainers to v1.29.0, ensuring the module’s out-of-the-box container startup targets the newer Docling Serve release.

Changes:

  • Bump DoclingServeContainerConfig.DOCLING_IMAGE_VERSION from v1.26.0 to v1.29.0.

Copilot AI review requested due to automatic review settings August 5, 2026 13:26
@edeandrea
edeandrea force-pushed the docling-serve-1.29.0 branch from 6333941 to a3626b1 Compare August 5, 2026 13:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

docling-testcontainers/src/main/java/ai/docling/testcontainers/serve/config/DoclingServeContainerConfig.java:229

  • Brace/else layout here is inconsistent with the repository’s Spotless/Eclipse Java formatter configuration and is likely to be rewritten by spotlessApply (or fail spotlessCheck). Please format this as } else { on the same line to match the rest of the codebase.
      if (containerEnv != null) {
        this.containerEnv = new HashMap<>(containerEnv);
      }
      else {
        this.containerEnv = null;

Copilot AI review requested due to automatic review settings August 5, 2026 13:28
Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

:java_duke: JaCoCo coverage report

Overall Project 47.54% 🔴

There is no coverage information present for the Files changed

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
Gradle Test Results (all modules & JDKs)1792 ran1792 passed0 skipped0 failed
TestResult
No test annotations available

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 5, 2026 13:57
…nsistency

Signed-off-by: Eric Deandrea <eric.deandrea@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (4)

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:101

  • Import ordering does not match the repository Spotless import order (see .spotless/import-order.txt: org then com then ai). The com.github.tomakehurst.wiremock.* imports are currently after the ai.docling.* imports, which will cause spotlessCheck to fail.
import ai.docling.serve.api.validation.ValidationErrorDetail;
import ai.docling.serve.api.validation.ValidationException;
import ai.docling.serve.client.DoclingServeClient.DoclingServeClientBuilder;
import ai.docling.testcontainers.serve.DoclingServeContainer;
import ai.docling.testcontainers.serve.config.DoclingServeContainerConfig;

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:1839

  • This assertion block contains commented-out expectations for input/context, which makes the test harder to read and maintain. If these fields are no longer stable across docling-serve versions, prefer explicitly ignoring them in the recursive comparison and remove the commented code.
//                      ValidationErrorContext.builder()
//                          .expectedSchemes("'http' or 'https'")
//                          .build()
//                  ).build()
          );

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:1766

  • This assertion block contains commented-out expectations for input/context, which makes the test harder to read and maintain. If these fields are no longer stable across docling-serve versions, prefer explicitly ignoring them in the recursive comparison and remove the commented code.
//                      ValidationErrorContext.builder()
//                          .expectedSchemes("'http' or 'https'")
//                          .build()
//                  ).build()
          );

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:524

  • This assertion block contains commented-out expectations for input/context, which makes the test harder to read and maintain. If these fields are no longer stable across docling-serve versions, prefer explicitly ignoring them in the recursive comparison and remove the commented code.

This issue also appears in the following locations of the same file:

  • line 1762
  • line 1835
//                          .expectedSchemes("'http' or 'https'")
//                          .build()
//                  ).build()
          );
    }

Copilot AI review requested due to automatic review settings August 5, 2026 14:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (4)

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:1764

  • This validation-error test still contains commented-out assertions for input/context, which leaves dead code and obscures what behavior is being verified. Prefer an explicit assertion strategy (e.g., compare only the stable fields) rather than commented code.
//                  .input(file.toUri().toString())
//                  .context(
//                      ValidationErrorContext.builder()
//                          .expectedSchemes("'http' or 'https'")
//                          .build()

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:1837

  • This validation-error test includes commented-out builder calls for input/context. Commented code in assertions makes the test intent ambiguous and tends to accumulate. Make the comparison explicit (compare only stable fields, or update expected values) and remove the commented block.
//                  .input(file.toUri().toString())
//                  .context(
//                      ValidationErrorContext.builder()
//                          .expectedSchemes("'http' or 'https'")
//                          .build()

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:521

  • The validation-error assertion currently contains commented-out builder calls for input/context, leaving dead code in the test and making it unclear which fields are intended to be asserted. Instead of commented code, make the assertion explicit (e.g., compare only type/message/locations, or update expected values to match the actual response).

This issue also appears in the following locations of the same file:

  • line 1760
  • line 1833
//                  .input(file.toUri().toString())
//                  .context(
//                      ValidationErrorContext.builder()
//                          .expectedSchemes("'http' or 'https'")
//                          .build()

docling-serve/docling-serve-client/src/test/java/ai/docling/serve/client/AbstractDoclingServeClientTests.java:125

  • The PR title/description says this is only a docling-serve container image version bump, but this file includes broad reformatting and behavior changes in tests (e.g., relaxed validation-error assertions). Please split the formatting/test changes into a separate PR (or clearly justify why they are required for the image bump) to keep the upgrade reviewable.
          """.formatted(
          getClass().getName(), context.getTestMethod().map(Method::getName).orElse(""), Optional.ofNullable(cause).map(Throwable::getMessage).orElse(""), doclingContainer
              .getLogs());

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@edeandrea
edeandrea merged commit e016499 into main Aug 5, 2026
27 checks passed
@edeandrea
edeandrea deleted the docling-serve-1.29.0 branch August 5, 2026 14:15
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants