[JVM] Drop support for glibc 2.17. - #12442
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI pipeline for JVM and Python packaging to stop targeting glibc 2.17 / manylinux2014 and instead use the newer manylinux_2_28 (glibc 2.28) baseline, aligning JVM native builds with the repository’s newer manylinux target.
Changes:
- Switch JVM manylinux build to
manylinux_2_28(glibc 2.28) and update the JVM tests workflow/job naming accordingly. - Improve JVM CI efficiency by stashing/unstashing the built
libxgboost4j.soand skipping native rebuilds when testing JVM packages. - Thread Maven options (GPU / skip native build) through Spark compatibility builds and example tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ops/pipeline/get-image-tag.sh | Adjusts CI image tag selection (currently hard-coded to a PR tag). |
| ops/pipeline/build-test-jvm-packages.sh | Reorders logic so Spark matrix builds and example tests receive consistent Maven options. |
| ops/pipeline/build-python-wheels-cpu.sh | Updates usage messaging to reflect manylinux_2_28 targeting. |
| ops/pipeline/build-jvm-manylinux.sh | Switches JVM native build container from manylinux2014 to manylinux_2_28 and keeps the built .so in place for downstream steps. |
| .github/workflows/jvm_tests.yml | Renames/rewires jobs for glibc 2.28 builds and adds S3 stash/unstash + integrity checks for the native library. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
trivialfis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref dmlc/xgboost-devops#102
changes