Migrate Windows VM to CTK 13.3 - #98
Merged
Merged
Conversation
This reverts commit 2bfed23.
for more information, see https://pre-commit.ci
trivialfis
marked this pull request as ready for review
August 2, 2026 23:29
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows Server 2022 AMI build to install CUDA 13.3 (CTK 13.3) and restructures provisioning so Visual Studio installation is split into multiple steps with Packer-managed reboots, improving reliability of the image build.
Changes:
- Split the previous monolithic
bootstrap.ps1install flow into dedicated scripts for Visual Studio install, workload install, verification, CUDA/R install, NVIDIA driver install, and driver verification. - Insert
windows-restartprovisioners between key install steps (VS, workload, NVIDIA driver) to handle installers that require reboot. - Add new verification scripts (
verify_vs.ps1,verify_nvidia_driver.ps1) and ignorepacker.login the Windows VM image directory.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vm_images/windows/windows.pkr.hcl | Adds stepwise provisioning and multiple controlled reboots; updates sysprep provisioner exit codes. |
| vm_images/windows/bootstrap.ps1 | Removes VS/CUDA/R installation from bootstrap to support the new split install flow. |
| vm_images/windows/install_vs.ps1 | Installs VS Community (and vcredist) while tolerating “reboot required” exit codes. |
| vm_images/windows/install_vs_workload.ps1 | Installs Native Desktop workload and tolerates “reboot required” exit codes. |
| vm_images/windows/verify_vs.ps1 | Verifies VS workload presence and extracts VS display version via vswhere. |
| vm_images/windows/install_cuda_r.ps1 | Installs CUDA 13.3 and R toolchain versions via Chocolatey. |
| vm_images/windows/install_nvidia_driver.ps1 | Downloads, signature-checks, extracts, and installs pinned NVIDIA GRID driver from S3. |
| vm_images/windows/verify_nvidia_driver.ps1 | Verifies driver install by running nvidia-smi.exe. |
| vm_images/windows/.gitignore | Ignores packer.log in the Windows image directory. |
Suppressed comments (1)
vm_images/windows/verify_vs.ps1:20
- Same wildcard-expansion issue here:
-products *should be quoted to avoid PowerShell expanding it to filenames before callingvswhere.
$displayVersion = & $vswhere `
-latest `
-products * `
-property catalog_productDisplayVersion
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trivialfis
had a problem deploying
to
containers-staging
August 3, 2026 04:21 — with
GitHub Actions
Failure
chyunsu3
approved these changes
Aug 3, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Windows AMI. In addition, it splits the bootstrap script to insert a reboot provisioned by Packer after Visual Studio is installed. The installation returns a non-zero code without a reboot.
TODOs: