Don't confirm Spring actuator CRITICAL from a generic HTTP 200 - #33
Draft
cursor[bot] wants to merge 1 commit into
Draft
Don't confirm Spring actuator CRITICAL from a generic HTTP 200#33cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
probe_spring_actuator treated any 200 with a body longer than 5 bytes as confirmed CWE-215 CRITICAL. Fusion pins probe-confirmed findings, so SPA catch-alls, login pages, and generic JSON errors on :8080 became un-droppable credential-exposure reports. Require the same actuator body markers already used by check_http_admin_panels. Co-authored-by: dmitryflynn <dmitryflynn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
probe_spring_actuator()treated any HTTP 200 whose body was longer than 5 bytes as confirmed CWE-215 CRITICAL (credentials in/actuator/env, JVM heap dump at/actuator/heapdump). Fusion then pins probe-confirmed findings as un-droppable.--probe/--fullruns this on ports 8080, 8443, 8000, 8001, 8008, 8888 (andhttp-alt). A SPA catch-all, a login page after urllib follows a 3xx, or a generic JSON error that includes the request path is enough to report confirmed credential exposure.The sibling probe
check_http_admin_panels()was already hardened (content markers + SPA catch-all tests). This duplicate path was not, so the false CRITICAL still reachedvuln_probe_resultand the fusion gate.Trigger:
--probe/--fullagainst a host with port 8080 open whereGET /actuator/envreturns HTTP 200 with a generic HTML or JSON body that is not byte-identical to a random-path 404 (path-in-body error JSON, CSRF/nonce in an SPA shell, redirect-to-login).Root cause
Confirmation was
status == 200 and len(body.strip()) > 5with no actuator semantics.phpinfoin the same file already requiresPHP Version+<table; admin-panel probes already requirepropertySources/JAVA PROFILE.Fix
Require the same distinctive body markers as
check_http_admin_panelsbefore confirming each actuator path (propertySources/systemEnvironment,JAVA PROFILE/HPROF,dispatcherServlets/dispatcherHandlers,configuredLevel/effectiveLevel, etc.).Validation
python3 -m pytest test_probers.py -q— 46 passed