Don't skip CVE Phase 2 re-verification on a TypeError - #31
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The default-engine verifier2 sensor passed the host context dict as cve_ids and omitted phase1_results, so reverify_with_context always TypeError'd. The exception was swallowed as a warning, which silently dropped Phase 2 re-verification on every AI-enabled scan. Co-authored-by: dmitryflynn <dmitryflynn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
On every AI-enabled scan that produced Phase 1 verifier signals, the default-engine verifier Phase 2 sensor crashed with
TypeError: reverify_with_context() missing 1 required positional argument: 'phase1_results'.The exception is caught and logged as a warning, so the scan still finishes — but Phase 2 CVE re-verification never runs. Failed Phase 1 probes never get a second chance with full host context. Fusion treats leftover version-only CVE leads as non-findings, so confirmable CVEs stay unconfirmed.
Deep-probe scans already called the planner correctly (
src/deep/coordinator.py). Only the defaultsrc/engine.pysensor was broken.Root cause
_run_verifier2called:reverify_with_contextrequires(cve_ids, phase1_results, context=..., complete=...). The context dict was passed ascve_ids, andphase1_resultswas omitted.Fix
Match the deep-scan path: collect unconfirmed
CVE-*claims from Phase 1 signals, skip when none remain, and passcve_ids,phase1_results,context, andcompleteexplicitly.Validation
python3 -m pytest test_verifier_sanitize.py -q— 21 passed (including new Phase 2 wiring tests)._run_verifier2call with the realreverify_with_contextno longer emits a TypeError warning.