Don't fail agent-owned scans on controller restart - #30
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
ScanJob.from_dict treated every running job as an in-process zombie and marked it failed. Remote agents keep executing across a controller restart; try_set_terminal then refused POST /complete and the results were discarded. Leave assigned running jobs running so the agent can finish; only unassigned running jobs (no agent will complete them) are failed on reload. Same rule on graceful shutdown. Co-authored-by: dmitryflynn <dmitryflynn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A controller restart (crash, deploy, reboot) reloaded every
runningjob as failed — including scans a remote agent was still executing.try_set_terminalthen refusedPOST /complete, so the agent's results were discarded and the UI showed "Scan interrupted by server restart."Trigger: Postgres/SaaS (or any remote agent) → job is
runningon an agent → API process restarts → agent POSTs complete → 200 withstatus: failedand no terminaldoneevent.Fix:
ScanJob.from_dictonly fails running jobs that have noassigned_agent_id(true in-process zombies). Assigned jobs stayrunningso the agent can complete. Graceful shutdown uses the same rule. Dead agents are still handled byreclaim_stale_jobs.Tests: reload keeps assigned running jobs; unassigned running jobs still fail; full agent lifecycle survives a simulated restart and retains pre-restart events.