Merge to main for release#1224
Merged
Merged
Conversation
Returns all headers without reading full object
Used when calculating how to increment/decrement values when things are changed
Updated callsites that use Decrement to use new Adjust as more flexible
Captures possibility of s3Ambient -> external update leaving flag set
Maintains previous behaviour where s3 failure would still result in success, this is tolerant of failure to read header to get size. Possible failures reason would be a 404 manifesting as 403 if engine was missing s3:ListBucket permission
Edge case but found in testing, ensures we clear out previous size when incoming is a 0-byte adjunct.
Recent changes mean this can't be called for Adjuncts so remove bool
Load and update the ImageStorage record, rather than overwriting. Adjunct size is handled via different methods
Store "size" for s3-ambient adjuncts
Without this attribute the cleanup-handler will skip any handling, which can lead to resources hanging around
Reinstate "engineNotified" attribute on messages
Including "Authorization" header when making S3 proxy can result in an exception if using presignedUrl as aws detect 2 possible auth mechanisms. This strips from outgoing proxy request only, allowing the current auth header to be used for validation
Use TransformResponseAsync with cancellation token as existing method is obsolete. Use .Append() rather than .Add() for safety
Previous code hardcoded this to true. The behaviour is unchanged as yarp currently only returns true. This method currently runs synchronously to await doesn't alter any behaviour but avoids issues in the future if we update Yarp and behaviour changes
Strip "authorization" header before proxying to s3
Use named cache ttl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging
developintomainahead of new release.