fix(code): Return timezone-aware UTC datetimes from TemporarySchedule#405
Open
dknowles2 wants to merge 1 commit into
Open
fix(code): Return timezone-aware UTC datetimes from TemporarySchedule#405dknowles2 wants to merge 1 commit into
dknowles2 wants to merge 1 commit into
Conversation
Fixes #355 Previously, TemporarySchedule.from_json() used datetime.fromtimestamp() without a timezone argument, which converts the Unix timestamp to the local timezone of the host as a naive datetime. This could lead to confusing results when the server timezone differs from the user's expected timezone. Now, datetimes are returned as timezone-aware UTC datetimes, which is unambiguous and consistent with the rest of the library (e.g. Notification uses UTC-aware datetimes via fromisoformat).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #355
Previously,
TemporarySchedule.from_json()useddatetime.fromtimestamp()without a timezone argument, which converts the Unix timestamp to the local timezone of the host as a naive datetime. This could lead to confusing results when the server's timezone differs from the user's expected timezone.Now, datetimes are returned as timezone-aware UTC datetimes, which are unambiguous and consistent with the rest of the library (e.g.
Notificationalready uses UTC-aware datetimes viafromisoformat).Changes
TemporarySchedule.from_json(): passtz=UTCtodatetime.fromtimestamp()