downgrade severity of proto index event#277
Merged
Merged
Conversation
This is for open enumerations. We have some internal use cases where open enums are translated to proto enums which are open in proto 3 anyway. I think we should align the alloy and smithy translate behavior on this in the future, but for now downgrading this will unblock some use cases and we can revisit in the future.
lewisjkl
commented
May 12, 2026
| @@ -114,7 +114,7 @@ private List<ValidationEvent> validateShape(Model model, Shape shape) { | |||
| } else { | |||
| openEnumChecks = Stream.of(ValidationEvent.builder().id(OPEN_ENUM_MUST_NOT_HAVE_INDEXES) | |||
| .message("Members of enumeration" + shape + "must not have the `@protoIndex` trait applied.") | |||
Contributor
Author
There was a problem hiding this comment.
Keeping the message the same in case someone has logic built off of it.
benoitlouy
approved these changes
May 12, 2026
a-morales
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for open enumerations. We have some internal use cases where open enums are translated to proto enums which are open in proto 3 anyway. I think we should align the alloy and smithy translate behavior on this in the future, but for now downgrading this will unblock some use cases and we can revisit in the future.