Added sample shading to fix AA on specular surfaces. - #776
Open
gapys-krzysztof wants to merge 1 commit into
Open
Added sample shading to fix AA on specular surfaces.#776gapys-krzysztof wants to merge 1 commit into
gapys-krzysztof wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #753 the issue of AntiAliasing not covering specular surfaces level, to fights this GL_ARB_sample_shading is enabled and controlled/disabled via a custom variable
Sample shading disabled/set to 0
Sample shading enabled, set to 1
Sample shading increases the performance impact - it is fine on my GTX1080, but in case someone has such issues, you can set the var to some inbetween to balance quality to performance. Here's it set to 0.5f
The issue is not present with skip specular var enabled, but here's a pic with it off just in case, sample shading also disabled
Tested on Linux only