Skip to content

Adapt to ic-bn-lib changes, update crates#214

Merged
blind-oracle merged 2 commits into
mainfrom
igor/adapt-new-ic-bn-lib
Jul 14, 2026
Merged

Adapt to ic-bn-lib changes, update crates#214
blind-oracle merged 2 commits into
mainfrom
igor/adapt-new-ic-bn-lib

Conversation

@blind-oracle

Copy link
Copy Markdown
Collaborator
  • Fixes imports etc to align with a new unified ic-bn-lib, drop ic-bn-lib-common
  • Move WRR out
  • Update crates

@blind-oracle blind-oracle requested a review from a team as a code owner July 10, 2026 16:03
@zeropath-ai

zeropath-ai Bot commented Jul 10, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to cef7de1.

Security Overview
Detected Code Changes
Change Type Relevant files
Refactor ► benches/domain_lookup.rs
― Indentation/namespace adjustments and imports Change to use ic_bn_lib::{custom_domains::CustomDomain, principal} and adjust path for CustomDomain storage usage
Refactor ► benches/http_gateway.rs
― Import adjustments: switch from ic_bn_lib::http::body::buffer_body to ic_bn_lib::http::{body::buffer_body, server::conn::ConnInfo} and add principal; update other imports accordingly
Refactor ► benches/router.rs
― Import adjustments: use ic_bn_lib::{http::server::conn::ConnInfo, tasks::TaskManager} and reorder imports accordingly
Refactor ► src/api.rs
― Import adjustments: use ic_bn_lib::{health::Healthy, http::middleware::waf::{WafLayer}} and adjust module paths in test imports
Refactor ► src/cli.rs
― Import updates: http::{HeaderValue, Uri} and TLS/ACME related imports reorganized; switch to CustomDomainsCli type; update feature-gated paths and related struct fields
Refactor ► src/core.rs
― Core wiring: replace bnhttp::dns::Resolver with Resolver; adjust setup_custom_domains signature to use CustomDomainsCli; modify call site for custom domains setup
Refactor ► src/lib.rs
― Public re-exports: switch ProvidesCustomDomains export path from ic_bn_lib_common to ic_bn_lib; update module path accordingly
Refactor ► src/metrics/mod.rs
― Import path adjustments: include ConnInfo and Health-related types from updated ic_bn_lib paths; adjust module references accordingly
Refactor ► src/metrics/runner.rs
― Import path updates: replace ic_bn_lib_common::traits::Run with ic_bn_lib::tasks::Run; adjust RouteProvider import accordingly
Refactor ► src/policy/denylist.rs
― Import path change: use ic_bn_lib::http::Client instead of ic_bn_lib_common::http::Client; minor test import adjustments
Refactor ► src/policy/domain_canister.rs
― Import path update: ic_bn_lib::principal instead of ic_bn_lib_common::principal
Refactor ► src/routing/domain.rs
― Import updates: use ic_bn_lib::{ custom_domains::{CustomDomain, LooksUpCustomDomain, ProvidesCustomDomains, flags::DomainFlags}, health::Healthy, tasks::Run } and adjust related types
Refactor ► src/routing/error_cause.rs
― Import path adjustments for HttpError and related constants under updated module structure

@blind-oracle blind-oracle merged commit 5304ba4 into main Jul 14, 2026
6 of 7 checks passed
@blind-oracle blind-oracle deleted the igor/adapt-new-ic-bn-lib branch July 14, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants