Skip to content

fix: add project param in http query - #493

Closed
gjed wants to merge 4 commits into
devopshq:masterfrom
gjed:fix/project-in-http-query
Closed

fix: add project param in http query#493
gjed wants to merge 4 commits into
devopshq:masterfrom
gjed:fix/project-in-http-query

Conversation

@gjed

@gjed gjed commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Changes:

  • remove quotes from ArtifactoryBuildManager.builds method
  • add query with project param to ArtifactoryBuildManager._get_info method
  • add tests for changes

Refs: #452

gjed and others added 4 commits November 6, 2025 11:42
* Implement tests for ArtifactoryBuildManager to ensure project parameter is handled correctly.
* Verify that project query parameter is added to URLs without quotes.
* Include tests for builds property and _get_info method with project parameter.
Comment thread artifactory.py
url = ""
if self.project:
url = f"?project='{self.project}'"
url = f"?project={self.project}"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove quotes?

@allburov

Copy link
Copy Markdown
Member

Combined one #503

@allburov allburov closed this Jul 14, 2026
allburov added a commit that referenced this pull request Aug 19, 2026
closes #486 closes #493

Co-Authored-By: Marco <marco.pernigo.07@gmail.com>
Co-Authored-By: donhui <977675308@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants