Repository navigation
fix(github-config): accept the reviewed replacement publisher - #5093
Conversation
Prepare the documented two-revision transition from the current canonical publisher to v7.16.2. Regenerate only the github-config subject, retaining the deployed signer and legacy compatibility revisions. Review of e1681322..8d2203af found identical publisher workflow bytes and unchanged immutable publication/recovery helpers. The exact new identity is still a separate approval because its certificate SAN includes the ref. The approved renderer reports exactly one changed authorization entry: OCIRepository github-config/github-config. Record that new digest; no other consumer matcher or authorization entry changes. Part of #5092. Deploy before devantler-tech/.github#649; retain the old approval until a real publication under the replacement identity verifies.
Prepared at signed head The published v7.16.2 workflow is byte-identical to the currently approved publisher (SHA-256 The documented matcher writer changed only the configuration consumer. Sixteen checks against the actual before/after subjects prove the current signer remains accepted, the replacement changes from refused to accepted, both legacy compatibility signers remain accepted, and unknown revisions, mutable refs, other repositories/workflows, extra prefixes/suffixes and wrong issuers remain refused. Other consumers' matchers are unchanged. Using checksum-verified kubectl v1.36.2 with Kustomize v5.8.1, the production authorization validator first refused exactly one changed entry: Both local and production Hosted CI and semantic review remain pending. This receipt proves preparation and offline matcher behavior, not deployed acceptance or a new signed publication. Keep #5092 open; deploy and read back both exact identities before devantler-tech/.github#649 merges, then retain the current approval through the first verified publication under the replacement. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85188abf7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at
Promoting and entering the normal protected production queue. Keep #5092 open and keep devantler-tech/.github#649 blocked until deployed acceptance of both exact publisher identities is independently read back. No admin bypass or safety-gate change. |
Why
The pending publisher upgrade would stop configuration releases because Platform does not yet accept its signing identity.
What
Prepare the documented transition so releases signed by the current or reviewed replacement publisher can be verified. Retain the current signer until the replacement has published successfully.
Part of #5092