Repository navigation
docs: make AS Coaching approachable for new contributors - #303
Conversation
The documentation-only slice was checked against base ff0a22d. An independent reader used a fresh anonymous checkout with only the four draft files copied and owned dependency/browser caches. Installation, lint, typecheck, 54 unit tests, 13 browser tests, explicit build and all five documented wiring fixtures passed. Four local links/anchors and eight shell blocks passed, and all four guide digests match this slice. The required Lighthouse infrastructure completed three runs successfully without changing its policy. LCP retained a warn-level budget miss (2705.9–3003.6 ms against 2500 ms); performance scores were 0.94–0.95. This is not a claim that every performance budget passed. Dev and built previews both navigated Services, About and Contact to the correct sections, with empty contact fields; no real email, booking or external contact action occurred. Screenshots were unavailable, so the evidence is a DOM/user-path trial, not visual screenshot QA. Nested-worktree lint, typecheck, explicit build and the five local wiring fixtures passed. Its unit runner failed during optimizer startup before tests ran; that did not reproduce in the independent standalone checkout. The initial reader's duplicate npm-isolation config paths were corrected only in its disposable harness; source, setup commands and checks were not changed. Existing host tools are not fresh-host proof, and local browser assertions are not an actual Safari session, container-runtime validation or deployment proof. All owned trial processes, listeners and disposable files were cleaned up. |
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The local-preview link resolves to the correct README section. No actionable issue remains in the reviewed documentation changes. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Full details: Linked Issues check
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@coderabbitai The inconclusive Linked Issues check requested exact-head review and CI evidence; that evidence is now complete at 6caf713, base ff0a22d. Your substantive full review covers all four changed files and states that no actionable issue remains: #303 (comment). All five additional observations were inspected and request no source correction. The native CI run https://github.com/devantler-tech/ascoachingogvaner/actions/runs/38188471608 completed successfully, including unit and browser tests, build, required Lighthouse infrastructure, container smoke and CI - Required Checks. Native dependency review, CodeQL and workflow scanning also pass; there are no failing or pending applicable checks and GitHub reports CLEAN. There are no review threads. The prior local optimizer failure, reader limitations and warn-level Lighthouse metrics remain explicitly recorded in the validation comment, not described as passed or diagnosed. The required-gate helper confirms the CI aggregate and required workflows; its configured code-quality rule remains API-UNVERIFIED, separately from native successful CodeQL and GitHub's authoritative CLEAN enforcement. The live holder is self and the exact-head claim verifies. Fresh complete WIP is Verifying 2/3 and Ready to Merge 0/6; only development/review WIP is excepted. The repository PR template is preserved. This evidence satisfies the report's missing delivery-proof request without changing source, skipping checks, buying review credits or claiming every performance budget passed. Ready for promotion, then a fresh native merge check. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="devantler-tech/ascoachingogvaner"
head="6caf71337c13b669d8e6624063d7a6f42ceb44b8"
gh pr view 303 --repo "$repo" --json url,state,isDraft,headRefOid,baseRefOid,mergeStateStatus,reviewDecision,statusCheckRollup
gh api "repos/$repo/issues/comments/6115712750" --jq '{user: .user.login, body, html_url}'
gh api "repos/$repo/actions/runs/38188471608" --jq '{head_sha,status,conclusion,html_url,event}'
gh api --paginate "repos/$repo/commits/$head/check-runs?per_page=100" --jq '.check_runs[] | {name,status,conclusion,head_sha,details_url}'
gh api graphql -f query='query { repository(owner:"devantler-tech", name:"ascoachingogvaner") { pullRequest(number:303) { reviewThreads(first:100) { totalCount nodes { isResolved } pageInfo { hasNextPage } } } } }'Length of output: 29802
The recorded Lighthouse warnings and local validation limits remain separate from successful native CI results. The helper’s The earlier evidence gap is now closed. The published report still displays its earlier inconclusive result; this reply does not update that report. PR You are interacting with an AI system. |
1 participant
Why
New contributors need a clear local starting point and accurate ownership of the website's content and booking address. They should not need platform access or contact real clients to check a small improvement.
What
Provide reader-focused Danish setup and contribution guidance, correct the existing source-ownership descriptions, and protect the tailored guides from later template synchronization. Preserve accessibility, browser compatibility and delivery checks.
Fixes #302