Skip to content

fix(ci): adopt patched release and Go tools - #631

Merged
devantler merged 1 commit into
mainfrom
codex/tool-security-625
Oct 17, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/tool-security-625

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The shared release and validation tools are behind published security fixes. Every consumer inherits those older tools when it uses the catalogue.

What

Updates the release tool and the Go compilers used by the catalogue while preserving existing checks, permissions and consumer settings. Automated tracking of embedded tool versions remains a separate follow-up.

Fixes #625

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Upstream release review: semantic-release 25.0.3 → 25.0.9; Go 1.26.6/1.26.8 → 1.26.9 and the scanner compiler 1.27.1 → 1.27.2.

The complete semantic-release patch range was read: 25.0.4, 25.0.5, 25.0.6, 25.0.7, 25.0.8, and 25.0.9. Output redaction and input-handling security fixes are adopted here. Commit-message null handling and the patch-line consistency/revert fixes need no caller adaptation. The supported Node requirement remains compatible with the production Node 22 installation. No new caller-facing interface or local workaround replacement was identified.

The official Go release history covers the intervening 1.26.7/1.26.8 fixes and the 1.26.9/1.27.2 security and bug fixes. All eight module files that select catalogue compilers now choose 1.26.9. The production TODO compiler is aligned; scanner installation and the current scanner test matrix use 1.27.2. Caller-selected scan execution still uses GOTOOLCHAIN=local. Compatibility-only module declarations and intentionally vulnerable dependencies remain intact; the retained 1.25 compatibility matrix is not a claim of patched-toolchain adoption. Automated tracking remains #627.

Local evidence at the signed candidate: required manifest render and fourteen baseline checks passed, seven affected Go modules passed race tests and vet with Go 1.26.9, and complete CI credential traversal passed. The actual updated release command passed eleven release decisions and eight stable/default-branch decisions with unchanged files and refs. The existing configuration assertion failed before the production pin update and passed afterward. Independent static review found no correctness/security findings.

Hosted acceptance remains outstanding: this host has no Docker executable for the native TODO replay. A scanner retry process-name fixture also cannot identify its test process on this host; its assertions were not changed. Required hosted CI must demonstrate those runtime paths before promotion. No publication, consumer rollout or completed delivery is claimed yet.

@github-code-quality

github-code-quality Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 945434b codex/tool-security-... f681c81 +/-
50% 50% 0%

C# / code-coverage/dotnet

main 945434b codex/tool-security-... f681c81 +/-
100% 100% 0%

Go / code-coverage/go

main 945434b codex/tool-security-... f681c81 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 17, 2026 21:42 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Native user-path acceptance passed at head f681c815d1a5c86ca325fa9b727c579f2b920f74, CI run 39071369682 attempt 1. Actual checkout fc27794235b9df899454cc973d18601484d20f96 has the same tree as the reviewed head, c38f7229983dc9dda5f38618bdfb400ca627cb65, with the exact reviewed base/head as parents.

  • Native TODO container replay 117509520977 used Go 1.26.9 and passed its actual image, discovery and payload-regression controls. This closes the missing-Docker host gate.
  • Native release controls 117509644975 acquired semantic-release 25.0.9 and passed actual release decisions, seven behavior regressions, eight stable-channel decisions and their observation mutations. Both credential-free caller settings also passed (117509521339, 117509521450).
  • Both strict and allowlisted scanner cases passed on 1.26.9 and 1.27.2, retaining generic-method coverage; the real timed-out-scan recovery job 117509645001 passed. This supplies the native Linux process proof missing on this host.
  • Native naming, retired-link and shell-pipeline action fixtures passed, including Linux/macOS and rejection paths; the deliberately failing Go-test fixture was correctly rejected.

Every readable required check/workflow passed. The configured code-quality rule remains unreadable through the completeness API (UNVERIFIED); this is not reported as COMPLETE. Promotion still needs a current-head green review, and any merge must be the ordinary protected operation at the evaluated head. Publication and consumer propagation remain post-merge checks.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4d609304-10fe-49fb-9d88-86d17e9c367a
📥 Commits

Reviewing files that changed from the base of the PR and between 945434b and f681c81.

📒 Files selected for processing: 15
  • .github/actions/govulncheck/action.yaml
  • .github/scripts/delete-workflow-runs/go.mod
  • .github/tests/catalogue-credentials/go.mod
  • .github/tests/create-release-fixture.sh
  • .github/tests/create-release-stable-channel-fixture.sh
  • .github/tests/go-test-fixture/go.mod
  • .github/tests/test-create-release-config.sh
  • .github/tests/todo-scanner/go.mod
  • .github/workflows/ci.yaml
  • .github/workflows/create-release.yaml
  • .scripts/todo-guard/go.mod
  • actions/create-issues-from-todos/action.yaml
  • actions/validate-naming/go.mod
  • actions/validate-retired-repo-links/go.mod
  • actions/validate-shell-pipelines/go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🧰 Additional context used
📚 Code guidelines: 3
AGENTS.md — auto-discovered
actions/CONTRIBUTING.md — auto-discovered
CONTRIBUTING.md — auto-discovered
📓 Path-based instructions: 4
Source excerpt: Full detail in [actions/CONTRIBUTING.md](actions/CONTRIBUTING.md).

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/scripts/delete-workflow-runs/go.mod
  • .github/tests/todo-scanner/go.mod
  • actions/validate-naming/go.mod
  • actions/create-issues-from-todos/action.yaml
  • actions/validate-shell-pipelines/go.mod
  • .github/tests/go-test-fixture/go.mod
  • .github/tests/create-release-stable-channel-fixture.sh
  • .github/tests/test-create-release-config.sh
  • .scripts/todo-guard/go.mod
  • actions/validate-retired-repo-links/go.mod
  • .github/tests/catalogue-credentials/go.mod
  • .github/tests/create-release-fixture.sh
  • .github/workflows/create-release.yaml
  • .github/actions/govulncheck/action.yaml
  • .github/workflows/ci.yaml
Source excerpt: Every `.github/tests/test-*.sh` is a test entrypoint and must have an explicit invocation in a `ci.yaml` step's `run:` block.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/tests/test-create-release-config.sh
  • .github/workflows/ci.yaml
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Full detail in [actions/CONTRIBUTING.md](actions/CONTRIBUTING.md).

📄 CodeRabbit inference engine (actions/CONTRIBUTING.md)

Files:

  • actions/validate-naming/go.mod
  • actions/create-issues-from-todos/action.yaml
  • actions/validate-shell-pipelines/go.mod
  • .github/tests/test-create-release-config.sh
  • actions/validate-retired-repo-links/go.mod
  • .github/workflows/ci.yaml
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Three things share one repo: **The org's public profile** — `profile/README.md` (rendered on the org page), plus the org-wide community health files i...

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Files:

  • .github/scripts/delete-workflow-runs/go.mod
  • .github/tests/todo-scanner/go.mod
  • .github/tests/go-test-fixture/go.mod
  • .github/tests/create-release-stable-channel-fixture.sh
  • .github/tests/test-create-release-config.sh
  • .github/tests/catalogue-credentials/go.mod
  • .github/tests/create-release-fixture.sh
  • .github/workflows/create-release.yaml
  • .github/actions/govulncheck/action.yaml
  • .github/workflows/ci.yaml
🔇 Additional comments: 15
.github/workflows/create-release.yaml: 1

325-325: LGTM!

Also applies to: 387-387

.github/workflows/ci.yaml: 1

4226-4226: LGTM!

Also applies to: 4581-4581, 4628-4628

.github/tests/create-release-fixture.sh: 1

38-38: LGTM!

.github/tests/create-release-stable-channel-fixture.sh: 1

20-20: LGTM!

.github/tests/test-create-release-config.sh: 1

19-19: LGTM!

.github/actions/govulncheck/action.yaml: 1

54-54: LGTM!

actions/create-issues-from-todos/action.yaml: 1

65-65: LGTM!

.github/scripts/delete-workflow-runs/go.mod: 1

3-3: LGTM!

.github/tests/catalogue-credentials/go.mod: 1

3-3: LGTM!

.github/tests/go-test-fixture/go.mod: 1

3-3: LGTM!

.github/tests/todo-scanner/go.mod: 1

3-3: LGTM!

.scripts/todo-guard/go.mod: 1

3-3: LGTM!

actions/validate-naming/go.mod: 1

3-3: LGTM!

actions/validate-retired-repo-links/go.mod: 1

3-3: LGTM!

actions/validate-shell-pipelines/go.mod: 1

3-3: LGTM!

📝 Walkthrough

The release workflows and their checks now use semantic-release 25.0.9. Go version selectors, module declarations, and govulncheck fixture matrices now use updated Go patch versions. The scanner installation step uses Go 1.27.2, and the matrices retain Go 1.25.14.

Priority: ⬆️ High

Severity of issue fixed: High

Merge Risk: ⚪ Minimal · up to f681c

The release tooling and Go selectors use the requested patched versions while preserving the existing checks and caller-selected scan behavior. The reviewed configuration presents minimal merge risk; hosted CI should still exercise the native action paths.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive For #625, the supplied change summary shows all three semantic-release pins at 25.0.9, the fixed Go paths at 1.26.9, and the scanner installer and 1.27 matrix at 1.27.2. The summary also reports the… Provide hosted CI results for the native TODO replay and the scanner retry fixture. Then confirm that the affected action jobs pass.
Passed Passed checks: 4 passed
Check name Status Explanation
Out of Scope Changes check Passed The changed files update the release pins, Go selectors, Go module directives, release fixtures, and validation matrices identified by #625. The fixture and assertion updates support verification of t…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Title check Passed The title clearly and concisely describes the main changes: adopting patched release tooling and updated Go tools for CI.
Description check Passed The description is directly related to the changeset. It explains the security-driven updates to release tooling and Go compilers and notes the preserved CI behavior.
Full details: Out of Scope Changes check

Explanation

The changed files update the release pins, Go selectors, Go module directives, release fixtures, and validation matrices identified by #625. The fixture and assertion updates support verification of those version changes. The PR does not claim or implement the automated embedded-tool-version tracking assigned to #627.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. (12 skipped: 12 unsupported.)

Full details: Linked Issues check

Explanation

For #625, the supplied change summary shows all three semantic-release pins at 25.0.9, the fixed Go paths at 1.26.9, and the scanner installer and 1.27 matrix at 1.27.2. The summary also reports the required local validation. However, hosted acceptance for the native TODO replay and the scanner retry fixture remains outstanding, so the requirement that the affected native action jobs pass is not established.

Resolution

Provide hosted CI results for the native TODO replay and the scanner retry fixture. Then confirm that the affected action jobs pass.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at exact head f681c815d1a5c86ca325fa9b727c579f2b920f74, base 945434b46f0fc7a137ecb9ee772a294ff53b2d9a. Required CI and all readable workflow gates passed; native real-container, compiler, release-decision and scanner receipts are recorded above. Authenticated CodeRabbit review 6241826811 is GREEN at this head. Complete review reads contain six comments, no review objects or threads, no unresolved findings or human steering; ancillary checks reported no problem.

Native merge state is CLEAN. The configured code-quality gate is still API-unverifiable, so no claim of API completeness is made; ordinary protected promotion/merge remains the provider decision. After merge I will verify the exact merged source and the patch publication before closing the delivery record. Consumer adoption is not claimed by producer CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Take the semantic-release 25.0.9 and Go 1.26.9 security fixes on the shared release and validation paths

1 participant