Repository navigation
fix(github): keep new Pages bootstrap outside ongoing writes - #622
Conversation
Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
The bootstrap-domain mutation first reproduced a false success in the audit. With this repair, matching initial Pages settings pass; a changed domain reports drift, an unreadable site fails closed, and declaring both ongoing and bootstrap-only Pages owners is rejected. The ordinary repository update-policy tests and ShellCheck pass. Ran the actual read-only repository drift audit against the rendered change: all 27 declared repositories match live GitHub settings, including this Pages expectation. The provider CRD confirms that The settings repair does not publish the documentation or activate its DNS tenant. |
Code coverage overviewLanguages: Go, C# Go / code-coverage/test
C# / code-coverage/dotnet
Go / code-coverage/go
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at
Ready to merge. The next verification is the repository resource's Synced/Ready state and absence of further Pages PUT errors. |
Post-merge recovery confirmed: commit The managed repository is now generation 6, with Pages declared only as an initial setting and ordinary repository updates retained. Fresh readback reports This completes the settings-owner repair. Documentation DNS and public HTTPS remain tracked in platform #4939. |
Why
The newly created documentation site left repository settings stuck in a permission error because the managed GitHub App tried to update Pages. The matching bootstrap settings did not establish the observation needed for ongoing management.
What
Keep Pages as an explicit bootstrap setting and preserve normal updates to the repository. Continue checking the live Pages domain and build settings through the read-only drift audit, which rejects changed, missing, or ambiguous settings.
Fixes #614