Fix/XSUP-72726/retry mechanism in BaseClient for older urllib3 that does not support the back-off jitter#45035
Conversation
…oes not support the back-off jitter
MosheEichler
added
release-notes-only
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
|
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tcarmeli1
added
the
ready-for-ai-review
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| - Retry is instantiated without the backoff_jitter kwarg (no TypeError is raised) | ||
| - The https:// adapter is mounted on the session with the configured retry object | ||
| """ | ||
| import CommonServerPython |
| Then: | ||
| - Retry is instantiated with the backoff_jitter kwarg set to the given value | ||
| """ | ||
| import CommonServerPython |
| - Retry is instantiated without the backoff_jitter kwarg (no TypeError is raised) | ||
| - The https:// adapter is mounted on the session with the configured retry object | ||
| """ | ||
| import CommonServerPython |
| Then: | ||
| - Retry is instantiated with the backoff_jitter kwarg set to the given value | ||
| """ | ||
| import CommonServerPython |
marketplace-ai-reviewer
removed
the
ready-for-ai-review
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I've reviewed the PR and have a few quick updates for you to look into. Please ensure the vendor's name is added to the metadata keywords, bump the pack version, and safeguard against a potential TypeError with older urllib3 versions in the tests. Let me know if you have any questions!
Additionally, please address the following file-level notes:
Packs/Base/pack_metadata.json: The vendor's name must appear in thekeywordsfield.Packs/Base/Scripts/CommonServerPython/CommonServerPython.py: Reminder: Pack version bump required.
@github-code-quality[bot], @marketplace-ai-reviewer, @DeanArbel, @MosheEichler please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
|
|
||
| def __init__(self, *args, **kwargs): | ||
| received_kwargs.update(kwargs) | ||
| super().__init__(*args, **kwargs) |
There was a problem hiding this comment.
Prevent potential TypeError in environments with older urllib3.
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
julieschwartz18
left a comment
julieschwartz18
left a comment
There was a problem hiding this comment.
@MosheEichler Doc review complete, looks good! Adding the label docs-approved
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
6 participants
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/XSUP-72726
Description
Added support for older urllib3 that does not support the back-off jitter
Must have