fix: support system NCCL installations - #738
Open
janbernloehr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepEP currently assumes NCCL is installed through the PyPI package
nvidia-nccl-cu12. This fails for standard Ubuntu installations where NCCLis provided externally, for example:
/usr/include/nccl.h/usr/lib/aarch64-linux-gnu/libnccl.soThis change:
HybridEP does not require this change: its NIXL path skips NCCL/DOCA, while its
DOCA path intentionally builds the bundled NCCL submodule components.
Testing (internal)
01dc3aaac82068020353dce2c302e38153c0bfaabuilt and installedsuccessfully with system NCCL.
deep_ep._Cmetadata validation andimport deep_eppassed.