fix(python): release userdata reference when prepare fails - #422
Open
030611 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python binding retains userdata manually so an asynchronous completion can return it later. When hf3fs_prep_io() returns a negative errno, no completion will be produced, but the retained reference was previously left behind.
Limit the GIL release to the native prepare call and release the manual reference on the error path after the GIL has been restored. The successful prepare/completion ownership path is unchanged.
This is separate from the userdata/iov reference cycle addressed by #421.
Validation:
I could not run the 3FS/FUSE integration path locally.