fix(data-placement): normalize peer recovery traffic constraints - #419
Open
030611 wants to merge 1 commit into
Open
fix(data-placement): normalize peer recovery traffic constraints#419030611 wants to merge 1 commit into
030611 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318.
calc_peer_recovery_trafficcurrently returns the number of groups shared by a disk pair, whileget_peer_trafficandcheck_solutionuse normalized recovery traffic:shared_groups * recovery_traffic_factor / (group_size - 1)This change uses the same unit in the Pyomo constraints. The EC expression is algebraically unchanged because its recovery factor is
group_size - 1; CR now accounts for recovery traffic being split across the other group members.The regression test uses the 2-(4,3,2) CR BIBD case. It is infeasible with the previous bound and feasible after normalization.
Tested with:
pytest test/test_model.py(18 passed)