Skip to content

fix(sync): handle truncate/extend operations correctly in syncing #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SF-Zhou merged 1 commit into from
Mar 27, 2026
Merged

fix(sync): handle truncate/extend operations correctly in syncing #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/storage/service/ReliableForwarding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,9 @@ CoTask<IOResult> ReliableForwarding::doForward(const UpdateReq &req,
updateReq.options.commitChainVer = target.vChainId.chainVer;
}

bool readForSyncing = req.payload.isWriteTruncateExtend() && isSyncing &&
(req.options.isSyncing || req.payload.length != req.payload.chunkSize);
bool readForSyncing = isSyncing && !req.payload.isRemove() &&
(req.options.isSyncing || req.payload.isTruncate() || req.payload.isExtend() ||
(req.payload.isWrite() && req.payload.length != req.payload.chunkSize));
Comment thread
SF-Zhou marked this conversation as resolved.
if (readForSyncing) {
auto recordGuard = syncingReadRecorder.record();

Expand Down
5 changes: 5 additions & 0 deletions src/storage/service/StorageOperator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,11 @@ CoTask<IOResult> StorageOperator::handleUpdate(ServiceRequestContext &requestCtx
XLOG(ERR, msg);
co_return makeError(StatusCode::kInvalidArg, std::move(msg));
}
if (req.options.isSyncing && (req.payload.isTruncate() || req.payload.isExtend())) {
auto msg = fmt::format("reject truncate/extend request from syncing client: {}", req);
Comment thread
SF-Zhou marked this conversation as resolved.
XLOG(ERR, msg);
co_return makeError(StatusCode::kInvalidArg, std::move(msg));
}

XLOGF(DBG1, "Start the replication process, target: {}, tag: {}, req: {}", target->targetId, req.tag, req);

Expand Down
Loading