Cannot add sources and javadoc to gradlePluginPublication

[mpetuska]

I get this error when trying to add sources and docs to the publication

Execution failed for task ':publishCentralPortalPluginMavenClonePublicationToCentralPortalStorageRepository'.
> Failed to publish publication 'centralPortalPluginMavenClone' to repository 'centralPortalStorage'
   > Invalid publication 'centralPortalPluginMavenClone': multiple artifacts with the identical extension and classifier ('jar.asc', 'sources').

Config file is as follows

@file:Suppress("UnstableApiUsage")

gradlePlugin {
  website = "xxx"
  vcsUrl = "xxx"
  plugins {
    create("xxx") {
      // ...
    }
  }
}

tasks {
  register<Jar>("javadocJar") {
    from(dokkatooGeneratePublicationHtml)
    archiveClassifier = "javadoc"
  }
  whenTaskAdded {
    // Needed to bypass missing task dependency declarations of the MavenDeployer
    if (name.contains("CentralPortal", ignoreCase = true) || name.contains("Github", ignoreCase = true)) {
      dependsOn("javadocJar", "sourcesJar", "jar")
    }
  }
}

deployer {
  content {
    gradlePluginComponents {
      sources(
        artifact = tasks.named("sourcesJar"),
        builtBy = tasks.named("sourcesJar"),
      )
      docs(
        artifact = tasks.named("javadocJar"),
        builtBy = tasks.named("javadocJar"),
      )
    }
  }
}

Any workarounds until the fix is released?

P.S. Publishing with empty source and javadoc jars work just fine (default configuration of gradlePluginComponents).

[mpetuska]

Looks like it was a misunderstanding of how the plugin works in this scenario on my part. I have managed to get it working now, however a smaller issue still remains - task dependencies are not configured correctly by the plugin. Namely, the publication fails without this extra input from my earlier snippet

tasks {
  whenTaskAdded {
    // Needed to bypass missing task dependency declarations of the MavenDeployer
    if (name.contains("CentralPortal", ignoreCase = true) || name.contains("Github", ignoreCase = true)) {
      dependsOn("javadocJar", "sourcesJar", "jar", "makeEmptySourcesJar", "makeEmptyDocJar")
    }
  }
}

[natario1]

Thanks for reporting! I'll check later today, glad you found a workaround.

[natario1]

I tried to replicate this in MavenDeployer's own deployment, which has:

val javadocs = tasks.register<Jar>("dokkaJavadocJar") {
    dependsOn(tasks.dokkaJavadoc)
    from(tasks.dokkaJavadoc.flatMap { it.outputDirectory })
    archiveClassifier.set("javadoc")
}

deployer {
    content {
        gradlePluginComponents {
            kotlinSources()
            docs(javadocs)
        }
    }
}

Tasks seem to be properly wired. Could there be a problem in your task definition (e.g. "dokkaJavadocJar" not depending on tasks.dokkaJavadoc?)? Or can you help me reproduce your issue?

Here's the build file: https://github.com/deepmedia/MavenDeployer/blob/main/deployer/build.gradle.kts

[mpetuska]

Odd, the issue was present with general tasks like jar too. I'll build a reproducer later today.

[mpetuska]

In the meantime try upgrading gradle version to latest as the errors I got were gradle configuration validation which has gotten stricter in recent releases.

[mpetuska]

Here's the promised reproducer. Left some instruction inside REAMDE.md.
deployer-reproducer.zip

[natario1]

Thanks. It should work if you do the following

• update to 0.17.0
• replace id("com.gradle.plugin-publish") version "1.3.0" with java-gradle-plugin

If you want to keep using com.gradle.plugin-publish (used to publish to the plugin portal), then you shouldn't add any docs() or sources() to MavenDeployer, because com.gradle.plugin-publish already adds both of them to the publication.

I recommend using the lower level java-gradle-plugin which will not add docs and sources to the publication, so that you can add them via the deployer DSL.

[UmairKhalid786]

For me, this issue was fixed by specifying

android {
 publishing {
      singleVariant("release")
 }
}