Update hmsh for gmsh 4.14.0 compatibility - #1
Open
H-Fukagawa wants to merge 1 commit into
Open
Conversation
Major changes: - Updated type system: NodeTag and ElementTag now use CSize instead of CInt - Updated Stack LTS resolver to lts-21.25 for GHC 9.4.8 compatibility - Added gmsh library paths to stack.yaml for proper linking - Updated C FFI function signatures to match gmsh 4.14.0 API C FFI updates: - gmshInitialize: Added 'run' parameter (hardcoded to True) - gmshModelAddPhysicalGroup: Added 'name' parameter (hardcoded to empty string) - gmshModelMeshGetElement: Added 'dim' and 'tag' output parameters - gmshModelMeshRemoveDuplicateNodes: Added 'dimTags' parameter (hardcoded to empty vector) - gmshModelOccAddSurfaceFilling: Added 10 parameters with default values: * degree=3, numPointsOnCurves=0, numIter=100, anisotropic=0 * tol2d=1e-4, tol3d=1e-4, tolAng=1e-2, tolCurv=1e-2 * maxDegree=0, maxSegments=0 - gmshModelOccAddCircle: Added 'zAxis' and 'xAxis' parameters (hardcoded to empty vectors) - gmshModelOccAddEllipse: Added 'zAxis' and 'xAxis' parameters (hardcoded to empty vectors) - gmshModelOccAddSpline: Added 'tangents' parameter (hardcoded to empty vector) Type system fixes: - Replaced problematic 'coerce' calls with 'S.unsafeCast' for vector type conversions - Added UndecidableSuperClasses language extension to handle superclass constraints Note: Several parameters are hardcoded with default values to maintain API compatibility. Future versions should consider making these configurable through optional parameters or configuration types. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes:
C FFI updates:
Type system fixes:
Note: Several parameters are hardcoded with default values to maintain API compatibility. Future versions should consider making these configurable through optional parameters or configuration types.
🤖 Generated with Claude Code