Repository navigation
fix(deps): clear the visualizer's npm advisories, including an RCE in next/og - #32
Merged
Merged
Conversation
… next/og `visualizer-web` and `docs-site` go from 23 open Dependabot alerts to none. The critical one needed the pin moved: `next` is pinned exactly, and 16.3.4 is inside the range of the `next/og` ImageResponse remote code execution, fixed in 16.3.6. The pin is now 16.3.7, still exact, still a patch inside 16.3, and `eslint-config-next` moves with it. 16.3.8 is out but is younger than the two-day `min-release-age`, so it waits. `npm audit fix` took the rest, all transitive: undici 7.30.0, ip-address 10.7.2, fast-uri 3.1.8 and brace-expansion 1.1.21 / 5.0.12 in the visualizer; joi 17.13.8, image-size 2.0.4, fast-uri and brace-expansion in docs-site. image-size now has a release outside the vulnerable range, which the last fix did not have. Verified: `make viz-check` passes, and `npm run build` writes `public/docs` and generates all nine pages. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This clears all 23 open Dependabot alerts on
visualizer-web/package-lock.jsonandvisualizer-web/docs-site/package-lock.json. Onlypackage.jsonand the two lockfiles change.The critical alert:
nextnext16.3.4 is inside the range of thenext/ogImageResponseremote code execution advisory, fixed in 16.3.6.nextis pinned to an exact version, sonpm audit fixcannot move it. The pin is now 16.3.7: still exact, still a patch inside 16.3.eslint-config-nextmoves from 16.3.0 to 16.3.7 with it.16.3.8 is out, but it is younger than the two-day
min-release-agecooldown, so it waits for a later bump.Indirect dependencies, via
npm audit fixNo overrides were needed.
visualizer-webvisualizer-webvisualizer-webvisualizer-webdocs-sitedocs-sitedocs-sitedocs-siteThe last dependency fix could not repair
image-size, because no safe release existed then. 2.0.3 and later are outside the vulnerable range.Out of scope
The Python alerts on
uv.lockandvalidator/uv.lock(PyJWT, urllib3, httpx2, accelerate, nltk, pytest, setuptools, torch) are not touched here.Release
This does not cut a release, because
visualizer-web/is outside the sdist.Test plan
npm auditreports 0 issues invisualizer-weband indocs-sitemake viz-check: eslint, tsc, knowledge bundle, doc links, GPU catalognpm run build: the Docusaurus build writespublic/docs, andnext buildon 16.3.7 generates all 9 pages