fix(NT8): guard destroyed prop View in GliderPropControllerSystem - #9419
Draft
eordano wants to merge 1 commit into
Draft
fix(NT8): guard destroyed prop View in GliderPropControllerSystem#9419eordano wants to merge 1 commit into
eordano wants to merge 1 commit into
Conversation
UNITY-EXPLORER-NT8 (824 evts/2 users): EcsSystemException [GliderPropControllerSystem]. The glider prop View is parented to the avatar transform; when the avatar GameObject is torn down by Unity, the child View is destroyed while the ECS GliderProp component still references it. CleanUpDestroyedAvatarsProp then dereferences the destroyed View (PrepareForNextActivation / .gameObject), throwing out of Update. Early-return on Unity-null View (overloaded ==), matching the codebase's SafeDestroy/null-guard idiom. Unverified (no Unity build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Production evidence (decentraland Sentry, archive snapshot 2026-07-17): - UNITY-EXPLORER-NT8: 39 events / 1 users, last seen 2026-07-06
decentraland-bot
added
the
ext-contribution
Contributor
|
Build skipped — no changes detected under |
Contributor
|
Slack notification sent to #explorer-ext-contributions for external review. |
NickKhalow
requested changes
Jul 28, 2026
NickKhalow
left a comment
NickKhalow
left a comment
Contributor
There was a problem hiding this comment.
It would be better to enforce the invariant at the type level rather than comments in the long term perspective. i.e. struct GliderProp should explicitly hold weak reference implying that GliderProp doesn't own the resource and the resource can be destroyed by external code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UNITY-EXPLORER-NT8 (824 evts/2 users): EcsSystemException [GliderPropControllerSystem]. The glider prop View is parented to the avatar transform; when the avatar GameObject is torn down by Unity, the child View is destroyed while the ECS GliderProp component still references it. CleanUpDestroyedAvatarsProp then dereferences the destroyed View (PrepareForNextActivation / .gameObject), throwing out of Update. Early-return on Unity-null View (overloaded ==), matching the codebase's SafeDestroy/null-guard idiom. Unverified (no Unity build).
fixes #8064
Supersedes #9405: moved from the fork into the org repo so CI workflows receive repository secrets (fork PRs do not).