Skip to content

feat: proximity voice chat - #7327

Closed
popuz wants to merge 170 commits into
devfrom
feat/proximity-voice-chat
Closed

feat: proximity voice chat#7327
popuz wants to merge 170 commits into
devfrom
feat/proximity-voice-chat

Conversation

@popuz

@popuz popuz commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

❗❗❗WIP (build testing) ❗❗❗

protocol PR
js-toolchain PR

ref how-to wiki

Pull Request Description

What does this PR change?

Test Instructions

Prerequisites

  • List any required setup steps
  • Include environment/configuration requirements

Test Steps

  1. First step
  2. Second step
  3. Expected result after step 2
  4. ...

Additional Testing Notes

  • Note any edge cases to verify
  • Mention specific areas that need careful testing
  • List known limitations or potential issues

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@popuz popuz self-assigned this Mar 4, 2026
@github-actions

github-actions Bot commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

badge

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit bd6fd87
Logs https://github.com/decentraland/unity-explorer/actions/runs/24244711662
Download Windows https://github.com/decentraland/unity-explorer/suites/64107709536/artifacts/6372315966
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/proximity-voice-chat/pr-20951-bd6fd87/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/64107709536/artifacts/6372210140
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/proximity-voice-chat/pr-20951-bd6fd87/Decentraland_macos.zip
Built on 2026-04-10T13:57:17Z

@popuz popuz added force-build Used to trigger a build on draft PR do not merge labels Mar 5, 2026
@popuz
popuz marked this pull request as ready for review March 5, 2026 10:16
@popuz
popuz requested review from a team as code owners March 5, 2026 10:16
@AnsisMalins

AnsisMalins commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

PR 7327

PR number: 7327
Windows change build
Windows baseline build
macOS change build
macOS baseline build

Intel Core i3

Change samples: 2671
Baseline samples: 2676

Metric Change Baseline Delta Improvement
CPU average 33.6 ms 33.6 ms 0.0 ms -0.1% ⚪
CPU 1% worst 57.6 ms 54.5 ms 3.2 ms -5.8% 🔴
CPU 0.1% worst 124.0 ms 112.5 ms 11.6 ms -10.3% 🔴
GPU average 14.4 ms 15.6 ms -1.2 ms 7.7% 🟢
GPU 1% worst 22.4 ms 21.0 ms 1.4 ms -6.7% 🔴
GPU 0.1% worst 25.8 ms 23.1 ms 2.7 ms -11.8% 🔴

This was referenced Apr 1, 2026
Open
Open
popuz and others added 17 commits April 7, 2026 17:39
@popuz
update docs
97eac88
@popuz
Merge remote-tracking branch 'origin/dev' into feat/proximity-voice-chat
01bc398 
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/World/SDKEntityTriggerAreaPlugin.cs
#	Explorer/Assets/DCL/Social/DCL.Social.asmdef
#	Explorer/Assets/DCL/UI/Sidebar/SidebarSettingsButton.prefab
#	Explorer/Assets/DCL/UI/Sidebar/SidebarUI.UpperLayout.prefab
#	Explorer/Assets/DCL/UI/Sidebar/SkyboxMenuView.prefab
#	scripts/package-lock.json
#	scripts/package.json
@popuz
patially working scene restriction
55dfda5
@popuz
fixed restriction not shown for the first scene
171ca25
@popuz
wip on sound wave animation
5bbd367
@popuz
wip on sound wave animation
15d13fb
@popuz
update tooltip when suppressed by the scene
8ff6e3f
@popuz
basic animation for speaking
b08c9ed
@popuz
adjusted clor for the animation
1858a10
@popuz
polished sound wave animation
be8caff
@popuz
add animation to the button color
7f92716
@popuz
small fields movement
f537753
@popuz
basics for intro tooltip
008c504
@popuz
polished intro popup
1c58596
@RominaMarchetti
Update NearbyVoice.Button.prefab
fd5bd42
@RominaMarchetti
Polish blocked tooltip UI
072946e
@RominaMarchetti
Polish FTUX popup UI
435071d
@popuz popuz added force-build Used to trigger a build on draft PR and removed force-build Used to trigger a build on draft PR labels Apr 10, 2026
@popuz
popuz marked this pull request as ready for review April 10, 2026 10:35
popuz added 3 commits April 10, 2026 14:23
@popuz
fixed issue with locked cursor for context menu - brought back wasCur…
51ba7d0 
…sorLockedWhenMenuOpened field and recovering cursor state
@popuz
Merge remote-tracking branch 'origin/dev' into feat/proximity-voice-chat
7b6196d 
# Conflicts:
#	Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs
#	Explorer/Assets/DCL/Infrastructure/MVC/MVCFacade/MVCManagerMenusAccessFacade.cs
#	Explorer/Assets/DCL/Infrastructure/Utility/DecentralandUrls/DecentralandUrl.cs
#	Explorer/Assets/DCL/Interaction/Systems/ProcessOtherAvatarsInteractionSystem.cs
#	Explorer/Assets/DCL/PluginSystem/Global/GlobalInteractionPlugin.cs
#	Explorer/Assets/DCL/UI/GenericContextMenu/Controllers/GenericUserProfileContextMenuController.cs
#	Explorer/Assets/Protocol/DecentralandProtocol/ComponentID.gen.cs
@popuz
Merge remote-tracking branch 'origin/fix/context-menu/cursor-return-t…
bd6fd87 
…o-locked' into feat/proximity-voice-chat
@popuz
popuz marked this pull request as draft April 16, 2026 15:58
@davidejensen
davidejensen deleted the feat/proximity-voice-chat branch June 9, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@AnsisMalins AnsisMalins AnsisMalins requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@popuz popuz

Labels

force-build Used to trigger a build on draft PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@popuz @AnsisMalins @davidejensen @RominaMarchetti