Skip to content

Scrum 100 make round configuration easier to access - #48

Merged
Mateusz-Dobrzynski merged 11 commits into
masterfrom
SCRUM-100-Make-round-configuration-easier-to-access
Jun 14, 2026
Merged

Scrum 100 make round configuration easier to access#48
Mateusz-Dobrzynski merged 11 commits into
masterfrom
SCRUM-100-Make-round-configuration-easier-to-access

Conversation

@Akirus12

@Akirus12 Akirus12 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description
This PR makes the round configuration for debates more clearly visible to the user, by making the link use a GenericButton as well as using string round parsing.

Testing

  • I have covered code introduced by this pull request with tests.
  • I have run all tests with npm run test && npx playwright test and ensured that they pass consistently.

Akirus12 added 5 commits June 12, 2026 18:00
…d props.smol to actually make the button small)

AND removed placeholder "ret" div text from DebateDetailsPage
…nto SCRUM-100-Make-round-configuration-easier-to-access
…and also implemented this change to the popup as well.

i also made the screen scroll up to the pop up when you click the button.

and small test changes to work with the new parsed strings.
…and also implemented this change to the popup as well.

i also made the screen scroll up to the pop up when you click the button.

and small test changes to work with the new parsed strings.
@Akirus12
Akirus12 requested a review from avocado-rice June 12, 2026 17:26
Comment thread src/components/tournament/dashboard/DashSide.tsx Outdated
Comment thread src/components/tournament/ladder/LadderRoundRow.tsx Outdated
Comment thread src/components/tournament/ladder/RoundConfig.tsx Outdated
Comment thread src/components/tournament/ladder/LadderRoundRow.tsx Outdated
Comment thread test/e2e/tournament-ladder-rendering.test.ts
Comment thread src/i18n/translations/en.json Outdated

@avocado-rice avocado-rice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mateusz-Dobrzynski
Mateusz-Dobrzynski merged commit 3da694f into master Jun 14, 2026
2 checks passed
@Mateusz-Dobrzynski
Mateusz-Dobrzynski deleted the SCRUM-100-Make-round-configuration-easier-to-access branch June 14, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants