Scrum 109 indicate currently active view on the sidebar - #41
Merged
Akirus12 merged 8 commits intoJun 14, 2026
Merged
Conversation
Mateusz-Dobrzynski
requested changes
Jun 8, 2026
Mateusz-Dobrzynski
left a comment
Mateusz-Dobrzynski
left a comment
Member
There was a problem hiding this comment.
The existing tests are passing for me, there must be something wrong with your setup. This PR also isn't covered with any kinds of tests and since the underlying logic is not exactly human-readable, I'd rather have it tested.
Contributor
Author
|
The test I added should be working but I keep having a timeout problem 😕 |
Mateusz-Dobrzynski
approved these changes
Jun 12, 2026
Mateusz-Dobrzynski
left a comment
Mateusz-Dobrzynski
left a comment
Member
There was a problem hiding this comment.
The version number needs bumping but the test is fine.
I've discovered that killing processes returned by ps aux | grep next resolves the the timeouts. This probably means that post-test teardown is not working 100% of the time.
Akirus12
approved these changes
Jun 14, 2026
coffeeaddictamoeba
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces highlighting the currently open page on the left sidebar.
Testing
npm run test && npx playwright testand ensured that they pass consistently.The playwright tests do not pass, can the reviewer check this out, maybe it's because of me using WSL. Thank youuuu