Test infra: pytest migration + tests / lint workflows (#23, #43, #44) - #50
Open
dbqpdb wants to merge 3 commits into
Open
Test infra: pytest migration + tests / lint workflows (#23, #43, #44)#50dbqpdb wants to merge 3 commits into
dbqpdb wants to merge 3 commits into
Conversation
Adds tests/test_rlm.py with one pytest function per TestRLM method. Bodies are delegated to TestRLM for now to keep the migration minimal; inlining as pytest-idiomatic tests can be a follow-up. Also adds pytest to environment.yml and a minimal .gitignore for __pycache__ / pytest cache. Verified locally with pytest 9.x: 5 passed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Runs on pull requests targeting master and on push events to master (i.e. post-merge). Uses Python 3.11; installs pytest + the runtime deps (numpy, pandas) via pip rather than reconstructing the full conda env. Note: the push trigger does NOT enable direct pushes to master — that is blocked by branch protection. The trigger only fires when a merge commit lands on master via a PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…44) Separate workflow file from tests.yml per the agreed CI convention. Triggers on every push (any branch) and every pull_request so lint issues surface during development rather than accumulating until a final merge to master. Uses continue-on-error so flake8 findings show up in CI without blocking merge — meant to land before #45 (PEP 8 cleanup), then flip to blocking once the codebase is clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets up the test infrastructure in three commits so each can be reviewed independently:
f77b51a— pytest migration (Unit testing #23): addstests/test_rlm.pywith one pytest function perTestRLMmethod. Bodies delegate toTestRLMfor the moment to keep this PR small; inlining as pytest-idiomatic tests is a clean follow-up. Addspytesttoenvironment.ymland a minimal.gitignore.599a9ea— tests CI workflow (CI: run unit tests on pull requests targeting master #43):.github/workflows/tests.yml. Runs on PRs tomasterand on push tomaster(post-merge). Installspytest numpy pandasvia pip and runspytest -v.c75d163— lint CI workflow (CI: lint for PEP 8 on pull requests targeting master (advisory) #44):.github/workflows/lint.yml. Runs on every push and every PR (not just master-targeted) so lint issues surface during development.flake8is run withcontinue-on-errorso findings are visible without blocking merge. Will flip to blocking after Cleanup: bring all code up to PEP 8 #45 (PEP 8 cleanup).Test plan
pytest -vlocally — 5 passed (with warnings that are tracked elsewhere: tuple-assert fixed by Quick bug bag: six independent small fixes (#29, #30, #31, #32, #33, #36) #49, regex escape sequences are Fix typo, regularize RegEx #28,TestRLMcollection warning goes away with the dead-code cleanup).Notes / known gaps
tests.ymldoes not enable direct pushes to master — that's blocked by branch protection. It just runs tests on the merged state of master after a PR lands.master, so the warning about the tuple-assert pattern will show up in CI output here. PR Quick bug bag: six independent small fixes (#29, #30, #31, #32, #33, #36) #49 (already open) fixes that and the warning will be gone once both PRs merge.Closes #23, #43, #44.
🤖 Generated with Claude Code