Conversation
royagrace
marked this pull request as ready for review
September 2, 2026 21:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now symlink the input weather files into a scratch tmp directory instead of tracked repo directories, so derived output lands outside the repo.
Description
Followed example from PR #814
Made changes based on PR Review notes:
Deleted the two tracked derived timeInterp .nc files, moved test_slant.py/test_datelist.py output and temp.yaml under tmp_path so those tests stop writing into the repo, and removed the blanket gunw_azimuth_test_data/ .gitignore entry so future accidental writes there show up in git status instead of being silently hidden.
Worth flagging in the PR: anyone with locally-modified copies of the two removed .nc files may see them as changed when pulling this — that's expected, not a conflict.
Motivation and Context
How Has This Been Tested?
Ran autopep8
Ran local tests
Screenshots (if appropriate):
Type of change
Checklist: