Repository navigation
build: pin the .NET SDK and add Dependabot - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI restore fails in locked mode with
NU1004:Microsoft.NET.ILLink.Taskschanged from[10.0.11, )to[10.0.12, ).The SDK adds that package as an implicit reference, at the version of the runtime it bundles.
global.jsonallowedrollForward: latestFeature, sosetup-dotnetinstalled the newest .NET 10 SDK, which bundles runtime 10.0.12, while the lock file still expected 10.0.11. Every SDK servicing release would break CI the same way. A floating SDK also changes the runtime bundled in the self-contained executable and the analyzers (withAnalysisLevel=latestand-warnaserror), with no commit recording it.Changes
global.json: pin the SDK to10.0.401withrollForward: disable, so CI and local builds use the same toolchain and runner-preinstalled SDKs are not picked upsrc/DaxLib.Mcp/packages.lock.json: regenerated with that SDK (Microsoft.NET.ILLink.Tasks10.0.12)AGENTS.md: explain why the SDK is pinned and how to update it together with the lock files.github/dependabot.yml: monthly updates for the .NET SDK (minor and patch only), NuGet packages (grouped), and GitHub ActionsNotes
dotnet restore DaxLib.Mcp.slnx --force-evaluate, commit, and push.Verification
Locally, with
RestoreLockedMode=true:dotnet build -warnaserror,dotnet test, anddotnet publish --runtime win-x64 --self-containedall succeed. CI on this PR confirms thatsetup-dotnetinstalls the pinned SDK.