Repository navigation
fix(cli): 1.33.1, --skill installs reported failure and were not tracked - #1503
Conversation
1.33.0 (#1467) replaced `source: 'github_main'` with a bare `source` in installIndividualSkill's trackDownload call, a variable that exists only in installIndividualMod. Every catalog skill install wrote its files, then threw "ReferenceError: source is not defined": the summary showed FAIL and a Retry line, a batch exited 1, and the download was never sent to Supabase. External skills (source.json) were not affected. - Restore source: 'github_main' - skill-install.node-test.js: --skill against a stubbed GitHub, asserting the files, the return value and the trackDownload call (fails on 1.33.0) - cli-ci.yml: npm ci + that test + an eslint no-undef pass over cli-tool/src and cli-tool/bin on CLI PRs (root npm test runs without dependencies) - Version 1.33.1 (not published), CHANGELOG Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012PXzcbUeN566p89EuSse2f
|
Generated by Claude Code |
[Medium impact] The PR affects catalog skill installs and checks on CLI changes. The fix appears safe to merge; expanding the workflow filters is a non-blocking improvement. Findings
SummaryRestores successful catalog skill installs by replacing the undefined
Reviews (1) · Last reviewed commit: "fix(cli): 1.33.1, --skill installs repor..." · Reviewed by Greptile |
| - 'cli-tool/tests/**' | ||
| - 'package.json' |
There was a problem hiding this comment.
CLI dependency changes skip checks
The new workflow skips PRs that change only cli-tool/package.json or cli-tool/package-lock.json. Those files define the CLI's own dependencies and release scripts, so dependency-only CLI changes miss this check. Add both files to the PR path filters so those changes receive the new checks too.
| - 'cli-tool/tests/**' | |
| - 'package.json' | |
| - 'cli-tool/tests/**' | |
| - 'cli-tool/package.json' | |
| - 'cli-tool/package-lock.json' | |
| - 'package.json' |
Requested by Daniel · project thread
What this PR does
Fixes the 1.33.0 regression behind the drop in skill installs and the red prod smoke test since run 76 (2026-11-09 01:43 UTC).
#1467 replaced
source: 'github_main'with a baresourceininstallIndividualSkill'strackDownloadcall (cli-tool/src/index.js:1536). The variable exists only ininstallIndividualMod. So every catalog skill install wrote all its files, then threwReferenceError: source is not defined, which the catch reported as anetwork_errorfailure:trackDownloadnever ran, so nocomponent_downloadsrow. GitHub rate limiting is not involved: SKILL.md (32,987 bytes) was downloaded in the failing smoke run. External skills (source.json) use a separate function and were not affected.source: 'github_main'.cli-tool/tests/unit/skill-install.node-test.js:--skillagainst a stubbed GitHub; checks the files, the exec bit,truereturned, and onetrackDownload('skill', …, {source: 'github_main'})+ asuccessoutcome. Fails on 1.33.0 with the same error..github/workflows/cli-ci.yml: the rootnpm testruns with no dependencies (version-sync.yml), so nothing loadedindex.jsbefore release. The new job runsnpm ci,npm run test:install-pathsandeslint@8.57.0 --rule no-undefovercli-tool/src+cli-tool/bin(browser-onlyanalytics-web/excluded). On 1.33.0 the lint flags exactly this line; on this branch it is clean.cctbinary removal (Remove the cct binary #1469), already onmain.Type
cli-tool/src,cli-tool/bin)dashboard/)How I tested it
--skill development/skill-creator→FAIL … source is not defined, files written.npm packof this branch, the smoke test's full batch (agent, command, mcp, hook, setting, skill, mod) against the real GitHub and aitmpl.com:Installed 7 of 7 · 0 failed, exit 0; skill-creator 17 files; nocctinbin/.npm test(root) green;npm run test:install-pathspasses on this branch and fails with the old line.Release: needs
npm publishfrom Daniel. Touchescli-tool/src,.github/andpackage.json, so it merges by hand (noautomerge).Generated by Claude Code
Summary by cubic
Fixes the 1.33.0 regression in the CLI (
cli-tool/) where every--skillinstall reported failure and was never download-tracked. AReferenceError: source is not definedininstallIndividualSkill's tracking call made the command write all files, then printFAIL, skip thecomponent_downloadsrow, and exit 1 in a batch. External skills (source.json) used a separate function and were unaffected.Bug Fixes
source: 'github_main'ininstallIndividualSkill'strackDownloadcall;--skillinstalls now returntrueand are counted assuccess.cli-tool/tests/unit/skill-install.node-test.js, a--skillinstall against a stubbed GitHub that asserts the files, exec bit, return value, andtrackDownloadpayload; it fails on 1.33.0 with the same error..github/workflows/cli-ci.ymlto runnpm ci,npm run test:install-paths, and aneslintno-undef pass overcli-tool/srcandcli-tool/binon CLI PRs; the rootnpm testpreviously ran without dependencies.docs/components.json) needs no regeneration.Written for commit af73a28. Summary will update on new commits.