-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Relative Effects and MDE for Ratio Metrics #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luizhsuperti
wants to merge
14
commits into
david26694:main
Choose a base branch
from
luizhsuperti:MDE-new-ratio-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
654d39c
add-backbone-of-calculations
luizhsuperti 041a284
delete backward compatiblility
luizhsuperti 286ac10
Update relative delta
luizhsuperti 3628494
add a test
luizhsuperti b68f0f0
Refactor DeltaMethodLiftTransformer to use standard error instead of …
luizhsuperti 8eb5170
Update relative_delta.ipynb
luizhsuperti e863186
Add_small_and_big_effects_ses
luizhsuperti 90e484d
fix: address david review comments on DeltaMethodLiftTransformer
luizhsuperti 2f98606
refactor exp. analysis and and lift transformer.
luizhsuperti 9d211ec
adjust minor bugs
luizhsuperti 7cc4da2
fix test
luizhsuperti bf24376
Merge branch 'main' into MDE-new-ratio-metrics
luizhsuperti f00ddc1
add-close-form-mde-relative-eff-outer-delta
luizhsuperti e67d729
Update relative_delta.ipynb
luizhsuperti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit confused in here, where is this method used? does this handle covariates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used by [_get_mean_standard_error] (p-value/SE path) and analysis_standard_error_with_stats(power path).
For Covariates: yes. It calls [_get_group_statistics] which builds [thetas_dict] from [self.covariates] and applies CUPED variance reduction inside [_get_group_mean_and_variance] So relative effects respect covariates.