fix(settings): persist custom model reasoning efforts correctly - #291
Merged
yaojin3616 merged 1 commit intoSep 4, 2026
Merged
Conversation
- Persist per-model reasoning levels through canonical reasoningEfforts. - Preserve existing wire aliases for configured levels. - Migrate valid legacy reasoning.efforts entries on edit. - Remove legacy reasoning in the same model update. - Remove the per-model default-effort selector. - Port PR dataelement#291 changes to Harness v0.1.2-rc.1. Co-authored-by: AtlaxTech <atlax-tech@outlook.com>
yaojin3616
force-pushed
the
fix/custom-provider-reasoning-efforts
branch
from
September 4, 2026 07:05
5961440 to
30b89ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix custom-model reasoning effort settings so they persist using the adapter's canonical
reasoningEffortsconfiguration field instead of the runtime-onlyreasoningdescriptor. This makes configured reasoning levels available in the conversation model picker for custom providers.What changed
reasoningEfforts.reasoning.effortsentries on edit.reasoningin the same model update.Verification
npm ci/ patch-package postinstall: PASSgit diff --check: PASSqwen3:8breasoningEfforts; legacyreasoninganddefaultEffortwere removed after save/reloadRelated