Skip to content

fix(settings): persist custom model reasoning efforts correctly - #291

Merged
yaojin3616 merged 1 commit into
dataelement:mainfrom
AtlaxTech:fix/custom-provider-reasoning-efforts
Sep 4, 2026
Merged

fix(settings): persist custom model reasoning efforts correctly#291
yaojin3616 merged 1 commit into
dataelement:mainfrom
AtlaxTech:fix/custom-provider-reasoning-efforts

Conversation

@AtlaxTech

Copy link
Copy Markdown
Contributor

Summary

Fix custom-model reasoning effort settings so they persist using the adapter's canonical reasoningEfforts configuration field instead of the runtime-only reasoning descriptor. This makes configured reasoning levels available in the conversation model picker for custom providers.

What changed

  • Persist per-model reasoning levels through reasoningEfforts.
  • Preserve existing wire aliases for configured levels.
  • Migrate valid legacy reasoning.efforts entries on edit.
  • Remove legacy reasoning in the same model update.
  • Remove the per-model default-effort selector, since the default belongs to provider/runtime resolution.
  • Add regression coverage for persistence, legacy migration, adapter schema compatibility, and complete custom-model object propagation.

Verification

  • Clean npm ci / patch-package postinstall: PASS
  • Focused regression: 9/9 PASS
  • Typecheck: PASS
  • Build: PASS
  • git diff --check: PASS
  • LAN tests with local-bind permission: 49/49 PASS
  • Full suite with local-bind permission: 670/671 PASS; the sole remaining failure is the pre-existing Feishu previous-tag assertion
  • Real runtime smoke using a custom OpenAI-compatible provider backed by local Ollama:
    • model: qwen3:8b
    • picker exposed Default / Low / High
    • High selected
    • request completed normally as a full assistant turn
  • Legacy lowercase reasoning configuration migrated successfully to canonical reasoningEfforts; legacy reasoning and defaultEffort were removed after save/reload

Related

- Persist per-model reasoning levels through canonical reasoningEfforts.
- Preserve existing wire aliases for configured levels.
- Migrate valid legacy reasoning.efforts entries on edit.
- Remove legacy reasoning in the same model update.
- Remove the per-model default-effort selector.
- Port PR dataelement#291 changes to Harness v0.1.2-rc.1.

Co-authored-by: AtlaxTech <atlax-tech@outlook.com>
@yaojin3616
yaojin3616 force-pushed the fix/custom-provider-reasoning-efforts branch from 5961440 to 30b89ad Compare September 4, 2026 07:05
@yaojin3616
yaojin3616 merged commit 12b0905 into dataelement:main Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants