Repository navigation
Make CanonicalizedMap.cast use the public key and value types - #1008
Open
hamed75kazemii wants to merge 1 commit into
Open
hamed75kazemii wants to merge 1 commit into
hamed75kazemii wants to merge 1 commit into
Conversation
The previous implementation cast the internal map of canonical keys and MapEntry values, so a same-type cast threw when the entry was read back as a key. Fixes dart-lang#629 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CanonicalizedMap.castforwarded to the private map, whose values areMapEntrys and whose keys are the canonical form.cast<String, String>()then threw when the entry was read as a key.Map.castFromon the publicMap<K, V>view.Fixes #629
Test plan
cast<String, String>()on a case-insensitive map returns the original values for both the stored key and its canonical formdart test test/canonicalized_map_test.dartinpkgs/collectionMade with Cursor