Repository navigation
Treat a trailing dot parent as the current directory in isWithin - #1007
Open
hamed75kazemii wants to merge 1 commit into
Open
hamed75kazemii wants to merge 1 commit into
hamed75kazemii wants to merge 1 commit into
Conversation
Comparing "/dir/." with "/dir/.file" matched the dot against the start of ".file" and reported the child as outside the directory. Fixes dart-lang#537 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isWithin('/dir/.', '/dir/.file')was false because the fast path matched the parent's trailing.against the first character of.file..component means the current directory, so/dir/.is the same directory as/dirand contains/dir/.file. A name such as.baris unchanged.Fixes #537
Test plan
.fileandfile, equals/dir, andfoo/./baris still not a parent offoo/.bar/baz(posix and Windows)dart test test/posix_test.dart --name isWithininsidepkgs/path(pub.dev was unreachable from this environment)Made with Cursor