fix: migrate SSH relay bootstrap paths from ~/.cmux to ~/.programa (#15)#33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
SSH-remote panels' relay warmup and TTY reporting were silently broken. The SSH bootstrap script generators in
CLI/cmux.swiftstill wrote to the old~/.cmux/...paths and looked for acmuxbinary on the remote host, while the rest of the daemon (Sources/Workspace.swift,daemon/remote/cmd/programad-remote/cli.go) already moved to~/.programa/...and theprogramabinary. The result: the remote relay CLI was never found, and the remote wrote the TTY name to a directory the Mac app never reads. This realigns the bootstrap scripts so SSH-remote relay actually works.Summary
16 remote-host string sites in
CLI/cmux.swiftmigrated:~/.cmux/relay/<port>.auth→~/.programa/relay/...~/.cmux/relay/→~/.programa/relay/~/.cmux/bin/cmux/command -v cmux→~/.programa/bin/programa/command -v programaPATHinjection andPROGRAMA_BUNDLED_CLI_PATH→~/.programa/bin/programaScope: only remote-host shell path/binary literals. No Swift symbols, local-Mac paths, DispatchQueue labels, theme bundle IDs, or product/scheme names were touched.
Note: three adjacent
command -v cmuxsites (session-end hook, codex hook) are also stale for the remote but fall outside this issue's scope and are left for a follow-up.Test Plan
tests_v2/test_ssh_remote_*.pysuite greenFixes #15