Skip to content

Code quality fix - "equals(Object obj)" and "hashCode()" should be overridden in pairs. - #69

Open
faisal-hameed wants to merge 1 commit into
darcy-framework:masterfrom
DevFactory:release/equals-and-hashcode-should-be-overriden-in-pairs-fix-1
Open

Code quality fix - "equals(Object obj)" and "hashCode()" should be overridden in pairs.#69
faisal-hameed wants to merge 1 commit into
darcy-framework:masterfrom
DevFactory:release/equals-and-hashcode-should-be-overriden-in-pairs-fix-1

Conversation

@faisal-hameed

Copy link
Copy Markdown
Contributor

This pull request is focused on resolving occurrences of Sonar rule
squid:S1206- "equals(Object obj)" and "hashCode()" should be overridden in pairs
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1206

Please let me know if you have any questions.

Faisal Hameed

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.5%) to 31.713% when pulling 3bedd87 on DevFactory:release/equals-and-hashcode-should-be-overriden-in-pairs-fix-1 into d074b3a on darcy-framework:master.

@alechenninger

Copy link
Copy Markdown
Member

Hi Faisal, thanks for the PR. Would you mind updating these equals() implementations to use Objects.equals(.., ...) instead? Also, I prefer not to see if blocks without braces.

I try to follow https://google.github.io/styleguide/javaguide.html except we use 4 space tabs. The point of note here is https://google.github.io/styleguide/javaguide.html#s4.1.1-braces-always-used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants