Skip to content

Compatible with php 8.3#122

Open
Alex300 wants to merge 4 commits into
dapphp:nextgenfrom
Alex300:nextgen
Open

Compatible with php 8.3#122
Alex300 wants to merge 4 commits into
dapphp:nextgenfrom
Alex300:nextgen

Conversation

@Alex300

@Alex300 Alex300 commented Sep 28, 2024

Copy link
Copy Markdown

Fix Deprecated: Implicit conversion from float to int loses precision
Fix dinamic creation object property is deprecated

@peterdd

peterdd commented Sep 28, 2024

Copy link
Copy Markdown

return type definitions are PHP 7+, securimage is PHP5.4+

(assuming there are still PHP5.6 installs at least)

https://wiki.php.net/rfc/return_types

@Alex300

Alex300 commented Sep 30, 2024

Copy link
Copy Markdown
Author

I removed return type definitions. I didn't even know that someone could use PHP 5.x

@perdedora

perdedora commented May 12, 2025

Copy link
Copy Markdown

The phpdoc for getCode is wrong. If $returnExisting is set to false, it will return an object somehow, not an array.


return type definitions are PHP 7+, securimage is PHP5.4+

Where did you got this information about PHP5.4+?
The README clearly states PHP7.0+ which already supports return types.

@dregad

dregad commented May 14, 2026

Copy link
Copy Markdown
Contributor

Where did you got this information about PHP5.4+?
The README clearly states PHP7.0+ which already supports return types.

This comes from composer.json, in the nextgen branch targeted by this PR:

securimage/composer.json

Lines 14 to 15 in 864ba75

"require": {
"php": ">=5.4",

Commit 680b1f5 only bumped the version in the README..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants