Repository navigation
Avoid panic when an Azure store has no subscription ID - #206
Open
theboringhumane wants to merge 1 commit into
Open
theboringhumane wants to merge 1 commit into
theboringhumane wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Azure store without
config.subscriptionIDreachesInitializeAzureStorewith a nil pointer and panics. Validate missing, null, empty and whitespace-only IDs inNewAzureStoreso initialization returns a configuration error before attempting authentication. The Azure documentation and type comment now state the existing requirement.Related to #179.
--store azurestill appends a configless store alongside configured YAML stores; this patch does not change that flag's store-selection behavior.Validation: the five invalid-configuration cases failed on the original constructor. All six regression cases and
GOMAXPROCS=2 go test -p 2 ./...pass with this change. The tests make no Azure requests.git diff --checkalso passes. The full lint/license/racemake checkwas not run.This change was prepared with AI assistance and received a separate code review before submission.