Skip to content

Do not submit snapshot on PRs only merge into master#45

Merged
dancewithheart merged 1 commit into
masterfrom
no-snapshot-submit-on-pr
Jun 9, 2026
Merged

Do not submit snapshot on PRs only merge into master#45
dancewithheart merged 1 commit into
masterfrom
no-snapshot-submit-on-pr

Conversation

@dancewithheart

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 32b050a9-a1a0-44c1-9986-1a129fcce104

📥 Commits

Reviewing files that changed from the base of the PR and between 0138d21 and 2e09ce5.

📒 Files selected for processing (1)
  • .github/workflows/submit_deps.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/submit_deps.yml

📝 Walkthrough

Walkthrough

The submit_deps workflow trigger configuration is simplified by removing the pull_request trigger. The workflow now activates only on direct push events to master/main and manual workflow_dispatch invocation.

Changes

Workflow Trigger Configuration

Layer / File(s) Summary
Remove pull_request trigger
.github/workflows/submit_deps.yml
The on: pull_request: trigger is removed from the workflow, leaving push to master/main and workflow_dispatch as the activation paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A workflow once triggered on every PR,
Now guards its dispatch with a push from afar,
No more pull requests ring the bell,
Just master and manual commands to tell,
Simpler flows, like a hop through the swell! 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to evaluate relatedness to the changeset. Add a pull request description explaining the rationale and impact of removing the pull_request trigger from the workflow.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: preventing snapshot submission on pull requests and only allowing it on merges to master.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch no-snapshot-submit-on-pr

Comment @coderabbitai help to get the list of available commands and usage tips.

@dancewithheart dancewithheart merged commit ff627e0 into master Jun 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant