Main.analyze returns the the dependency graph for a whole method body regardless of targetLineContents

[imlm]

Is this the correct behavior? Even though it receives the targetLineContents parameter, right now it only uses the line to find the method to generate the dependcy graph for.
E.g., if we analyze the line 15 ("z = a.x;") in the B class, the graph returned by Main.analyze will also contain dependencies for B.n_

[damorim]

the best approach to document the error is creating a test!

could you please add a test to reproduce this problem.

there are some samples on src-tests/core/Sanity.java showing how this can be done.

[imlm]

I can surely create a test, but I need to know the expected behavior for the method! :)
From the method signature I would assume that the returned graph should return dependencies for targetLineContents, but that's not the case right now!
If the current behavior is not the right one, then CoffeMaker.test0 should be failing and not passing!

[imlm]

Actually, disregard the last sentence, I think for this specific case it wouldn't make a difference picking the dependencies only for the wanted line or the whole method

[damorim]

i am confused.

do you want some clarification?
can you write a test case to show a problem?

if there is no pending question, please close this issue.

[imlm]

Just clarifying this issue:
This is not an issue related to Issue #11 , it is just a ṕossible bug in the implementation of the Main.analyze method.
When setting up the arguments for the analysis it does not include a targetLine argument

String[] args = new String[] {
        "-appJar="+appJar, 
        "-printWalaWarnings="+false, 
        "-exclusionFile="+exclusionFile, 
        "-exclusionFileForCallGraph="+exclusionFileForCallGraph, 
        "-dotPath="+dotPath, 
        "-appPrefix="+appPrefix,
        "-listAppClasses="+false, 
        "-listAllClasses="+false, 
        "-listAppMethods="+false, 
        "-genCallGraph="+false, 
        "-measureTime="+false, 
        "-reportType="+"dot"
        /** No "-targetLine=" argument **/
    };

This means that regardless of the targetLineContents argument, this method will always return the dependency graph for the whole target method, instead of just a line in that method.
For example, compare the dependency graphs generated with the genDDG script for the CoffeeMaker when specifying line 99 (default line) and when not specifying any lines. You will see that the results generated when not specifying a line will be the same generated by TestCoffeeMaker.test0, that does specify a line (line 99).

[damorim]

I see.

Irineu, the right approach to deal with this issue is to create a small test case similar to

src-tests/core.Sanity.testIR_isNotEmpty()

to reproduce the error: this test should initially fail!

Then you try to fix it. It does not look something hard to solve. For some reason, it looks like the analysis is ruling out ligitimate dependencies.

[MateusAraujoBorges]

Irineu, I think your example is invalid. Looking at TestCoffeeMaker.test0, I found that the test case uses the method depend.Main.analyze(...) to generate a SimpleGraph. This method only uses the targetLineContents argument to find the method to be analyzed - the dependency analysis is done without using line information.

[imlm]

Just "reopening" this discussion as I am facing a problem related to this issue.

Mateus, your comment

This method only uses the targetLineContents argument to find the method to be analyzed - the dependency analysis is done without using line information.

is exactly in line with what I said in the first comment for this issue

Even though it receives the targetLineContents parameter, right now it only uses the line to find the method to generate the dependcy graph for.

So my question in the beginning was if this is indeed the correct behavior for the method analyze. :)

I wanted to write a test case that targeted a specific line, but right now I can't use the analyze method due to its aforementioned behavior.
For now I will resort to following your example in the testAnalysisWithLineContents method and refactor later if needed.

If you believe that analyze method behavior is correct, please, close this issue.