Flag to enable &[u8] labels instead of &'static[u8].#73
Open
oleganza wants to merge 5 commits into
Open
Conversation
Merlin's src/lib.rs contains hard-failure for big-endian targets because I didn't test on them. The test was added to the CI, but the hard-failure wasn't removed, and cross now gives a linker error. So disable it entirely for now, and continue with the status quo (no big-endian support).
Update rand_core to 0.6, merlin to 3.0
|
Just fyi, I addressed this concern using IsLabel and AsLabel in https://docs.rs/ark-transcript/latest/ark_transcript/ It just makes you say that you know you're handling a label, but if your label is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Flame, I want to expose raw Transcript API (create, write, read) to smart contract code, so the labels cannot be
'static— they are supposed to be statically baked into contract code, but from the VM point of view that'd be a dynamically allocated string. This PR introduces a feature flag to relax the'staticrequirement, but IMHO it could be relaxed outright without a feature flag. Meanwhile I'm using the fork with that flag in my code.@hdevalence wdyt?