Repository navigation
fix(stdlib): import time/tzdata for reliable timezone lookup in times.in_location - #488
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
geseq
approved these changes
Oct 13, 2026
geseq
requested changes
Oct 13, 2026
geseq
left a comment
Collaborator
There was a problem hiding this comment.
Can you fix the failing CI please. The idea is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import
time/tzdatainstdlib/times.gosotime.LoadLocationfalls back to the embedded IANA timezone database when host zoneinfo is absent.Problem
Calls to
times.in_location(t, "Asia/Shanghai")fail withRuntime Error: unknown time zone Asia/Shanghaion operating systems without system zoneinfo (such as Windows) or in minimal container images.Solution
Import
_ "time/tzdata"in thestdlibpackage. The Go runtime uses the embedded database if the host system lacks timezone files. Add unit tests instdlib/times_test.gocovering standard timezone locations (Asia/Shanghai,UTC,America/New_York) and invalid location handling.Fixes #469