Skip to content

perf: skip image rebuild when image already exists (fast path for aidc up/claude) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ai-anant wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: skip image rebuild when image already exists (fast path for aidc up/claude) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ aidc up # build + start container
| `aidc rebuild` | rebuild the image and restart |
| `aidc destroy` | remove container + volumes + image (prompts; `-f` to skip) |

`aidc up` and the tool commands build the image only when it's missing; if the
image already exists they start the container directly (fast path). Force a
full rebuild with `aidc rebuild` (or `aidc rescan`). Set `AIDC_NO_BUILD=1`
in `.ai-container/project.env` to skip builds entirely — `aidc up` then fails
fast if the image is missing instead of building it.

## What lives where (inside the container)

```
Expand Down
37 changes: 35 additions & 2 deletions lib/aidc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ aidc::cmd_up() {
aidc::vm_ensure "$workspace"
fi

aidc::compose "$workspace" up -d --build workspace
aidc::compose_up "$workspace"
# Catch up the host with any transcripts a prior (possibly ungraceful) session
# left in the volume — the recovery case the on-exit hooks can't cover.
aidc::auto_sync_sessions "$workspace" all
Expand Down Expand Up @@ -1529,7 +1529,7 @@ aidc::ensure_container_running() {
fi

if [[ -z "$(aidc::compose_capture "$workspace" ps -q workspace)" ]]; then
aidc::compose "$workspace" up -d --build workspace
aidc::compose_up "$workspace"
# Only on the down→up transition (not every exec), so we recover prior
# transcripts without adding a sync to each command.
aidc::auto_sync_sessions "$workspace" all
Expand Down Expand Up @@ -1741,6 +1741,39 @@ aidc::compose() {
docker compose -f "$workspace/.devcontainer/compose.yaml" "$@"
}

# True when the compose image for the workspace already exists locally, so
# 'up' can skip a full rebuild. Resolves the image name from the compose
# config (which applies COMPOSE_PROJECT_NAME + build args) and checks it
# against the local image store. Returns non-zero when the image is missing
# or the compose project is not yet materialised.
aidc::image_exists() {
local workspace="$1"
local image
image="$(aidc::compose_capture "$workspace" config --images 2>/dev/null | head -n1)"
[[ -n "$image" ]] || return 1
docker image inspect "$image" >/dev/null 2>&1
}

# Start the workspace container, building only when needed:
# - image missing → full build (first run / after 'aidc destroy')
# - image present → no --build (fast path; compose still creates/starts)
# 'aidc rebuild' and 'aidc rescan' call compose directly with --build so
# they always force a rebuild. AIDC_NO_BUILD=1 opts out of builds entirely
# and fails fast if the image is missing.
aidc::compose_up() {
local workspace="$1"
if [[ "${AIDC_NO_BUILD:-0}" == "1" ]]; then
if ! aidc::image_exists "$workspace"; then
aidc::die "AIDC_NO_BUILD=1 but no image for $(basename "$workspace"); run 'aidc up' once or 'aidc rebuild'"
fi
aidc::compose "$workspace" up -d workspace
elif aidc::image_exists "$workspace"; then
aidc::compose "$workspace" up -d workspace
else
aidc::compose "$workspace" up -d --build workspace
fi
}

aidc::compose_capture() {
local workspace="$1"
shift
Expand Down