Fixed memory issue from metrics - #178
Open
abachma2 wants to merge 4 commits into
Open
Conversation
abachma2
changed the title
bam241
reviewed
Jan 25, 2021
| y.name = 'Mass' | ||
| z = y.reset_index() | ||
| return z | ||
| x['Mass'] = x['Quantity'] * x['MassFrac'] |
Member
There was a problem hiding this comment.
I think you'll need to "drop" [Quantity] and [MassFrac] column
katyhuff
requested changes
Jan 25, 2021
katyhuff
left a comment
katyhuff
left a comment
Member
There was a problem hiding this comment.
Please add a unit test that :
- Would have failed before this commit
- and passes now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I modified the 'Materials' metric to remove the memory error described in issue #177. Merging will close Issue #177. This method works, but if there are preferred methods to maintain efficiency of database structure I am open to changes.