55 correct dockers volume setup - #62
Merged
Merged
Conversation
…urpose of giving different input folders for different containers, so there is no file conflict for parallelization. allowed the possibility of storing input data in the results folder for transparency, or simply in /tmp/
refac: td models now does not pass "args" as argument to run command. that means that model src code should automatically read the input/{args} file, and specify {args} in its configuration if necessary. modified pymock from case_g for the new requirements, as well as fixed its Dockerfile to be compatible with new floatcsep versions.
… file. tests: modified tests to handle newly implemented docker volumes set up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DockerEnvironment should handle custom input volumes, so different model containers are able to set up their own input data for each time-window.