fix: clientside handling of relay websocket pings#3475
Merged
zunderscore merged 1 commit intocrowbartools:v5from May 1, 2026
Merged
fix: clientside handling of relay websocket pings#3475zunderscore merged 1 commit intocrowbartools:v5from
zunderscore merged 1 commit intocrowbartools:v5from
Conversation
zunderscore
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Handle relay websocket pings in Firebot to proactively reconnect if the connection drops
The ping logic is added only to relay websocket and not our ReconnectingWebsocket in order to keep ReconnectingWebsocket as generic as possible.
Applicable Issues
Reported in discord
Testing
Ensured relay websocket passes webhook messages as expected