Switch direction on mobile by tapping in the clue box#575
Merged
Conversation
Member
|
Thank you! I swear this worked at some point - I must have broken it 🤦 I'm just going to take a look when I have a chance and make sure nothing changed at the other breakpoints before merging. |
Member
|
I have been playing around with this a bit and so far looks great. The only issue I've found is in "clue mode" at the mobile breakpoint. It is supposed to look like this: 
But right now I'm seeing this: 
Up for taking a look at that sometime? |
Contributor
Author
|
Fixed. |
Member
|
Thank you! Merging and will deploy soon - will try to remember to let you know when it goes live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to the UI when solving a puzzle on a phone. When you tapped the selected clue to switch directions, you previously needed to tap on the actual text of the clue, not the box containing the clue. With this fix, you can tap the containing box to change directions, which gives you a large click target whose size is not dependent on the length of the clue.