avoid errors for non 0 indexed arrays - #135
Open
lekoala wants to merge 1 commit into
Open
Conversation
if you have an array like [ 1 => 'something', 2 => 'something else', ] for example, after array_unique or array_filter, then current code doesn't work. foreach will happily iterate on any values and seems a safer option (had the issue on my project, fixed it upstream by ensuring a properly 0 indexed array, but that seems good to have nonetheless)
Contributor
Author
|
@Nevett coud you have a look at this? |
Contributor
Author
|
or @Haziba ? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you have an array like
[
1 => 'something',
2 => 'something else',
]
for example, after array_unique or array_filter, then current code doesn't work. foreach will happily iterate on any values and seems a safer option
(had the issue on my project, fixed it upstream by ensuring a properly 0 indexed array, but that seems good to have nonetheless)